From: Brian Starkey <brian.starkey@arm.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: dri-devel@lists.freedesktop.org, airlied@linux.ie,
linux-kernel@vger.kernel.org, Liviu.Dudau@arm.com
Subject: Re: [PATCH] drm/i2c: tda998x: don't register the connector
Date: Mon, 25 Jul 2016 13:54:06 +0100 [thread overview]
Message-ID: <20160725125406.GB13937@e106950-lin.cambridge.arm.com> (raw)
In-Reply-To: <20160725122504.GS1041@n2100.armlinux.org.uk>
Hi Russell,
On Mon, Jul 25, 2016 at 01:25:04PM +0100, Russell King - ARM Linux wrote:
>On Mon, Jul 25, 2016 at 11:55:48AM +0100, Brian Starkey wrote:
>> The connector shouldn't be registered until the rest of the whole device
>> is set up, so that consistent state is presented to userspace.
>>
>> As drm_dev_register() now registers all of the connectors anyway,
>> there's no need to explicitly do it in individual drivers so remove
>> the calls to drm_connector_register()/drm_connector_unregister().
>>
>> This allows componentised drivers to use tda998x without having racy
>> initialisation.
>
>Is there a corresponding patch for armada-drm so that the cubox doesn't
>regress? Has it already been merged?
>
A patch for armada-drm to do what?
I should perhaps have explicitly mentioned that this change depends
on e28cd4d0a223: "drm: Automatically register/unregister all
connectors", which is in drm-next.
Like my commit message says - after the above commit, all connectors
are automatically registered in drm_dev_register() - so I don't
anticipate any regression, but I don't have a cubox to test.
armada-drm seems to be doing effectively the same thing as arm/hdlcd,
which works fine after this patch with no other changes.
Let me know if I've missed something; or if you are able to test on
cubox that would be great.
Thanks,
Brian
>-- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
>FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
>according to speedtest.net.
>
next prev parent reply other threads:[~2016-07-25 12:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 10:55 Brian Starkey
2016-07-25 12:25 ` Russell King - ARM Linux
2016-07-25 12:54 ` Brian Starkey [this message]
2016-07-25 15:08 ` Daniel Vetter
2016-08-08 16:04 ` Brian Starkey
2016-08-09 6:07 ` Daniel Vetter
2016-08-09 22:48 ` Russell King - ARM Linux
2016-09-21 8:57 ` Brian Starkey
2016-09-21 16:28 ` Russell King - ARM Linux
2016-09-22 10:39 ` Brian Starkey
2016-09-22 10:51 ` Russell King - ARM Linux
2016-09-22 11:22 ` Sean Paul
2016-09-22 11:28 ` Daniel Vetter
2016-09-22 13:38 ` Brian Starkey
2016-09-22 14:24 ` Russell King - ARM Linux
2016-09-22 12:09 ` Russell King - ARM Linux
2016-09-22 12:32 ` Sean Paul
2016-09-22 12:40 ` Russell King - ARM Linux
2016-09-23 7:07 ` Daniel Vetter
2016-09-22 14:14 ` Brian Starkey
2016-09-23 7:05 ` Daniel Vetter
2016-09-23 9:34 ` Liviu Dudau
2016-09-23 10:58 ` Daniel Vetter
2016-09-23 12:22 ` Lucas Stach
2016-09-23 12:52 ` Brian Starkey
2016-09-23 13:13 ` Daniel Vetter
2016-09-23 14:05 ` Russell King - ARM Linux
2016-09-25 20:34 ` Daniel Vetter
2016-09-23 14:42 ` Brian Starkey
2016-09-25 20:38 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725125406.GB13937@e106950-lin.cambridge.arm.com \
--to=brian.starkey@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®