From: Andrew Morton <akpm@linux-foundation.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
Michal Marek <mmarek@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 linux-next] kbuild: add make force=1 for testing
Date: Mon, 25 Jul 2016 17:05:55 -0700 [thread overview]
Message-ID: <20160725170555.fd4df28de067f2a689a2efc2@linux-foundation.org> (raw)
In-Reply-To: <1469366898-1496-1-git-send-email-fabf@skynet.be>
On Sun, 24 Jul 2016 15:28:18 +0200 Fabian Frederick <fabf@skynet.be> wrote:
> Commit 51193b76bfff
> ("kbuild: forbid kernel directory to contain spaces and colons")
>
> makes it impossible to build kernel on default SD labels like
> "SD Card" for instance.
>
> Makefile:133: *** main directory cannot contain spaces nor colons. Stop.
>
> User could rename directories but volume name is not always writable.
>
> This patch adds ability to do make force=1 for people
> not interested in modules_install in this case but only testing.
>
> (Note that other options could go under ifndef force)
That's a bit of a hack on a hack.
51193b76bfff said:
: When the kernel path contains a space or a colon somewhere in the path
: name, the modules_install target doesn't work anymore, as the path names
: are not enclosed in double quotes. It is also supposed that and O= build
: will suffer from the same weakness as modules_install.
:
: Instead of checking and improving kbuild to resist to directories
: including these characters, error out early to prevent any build if the
: kernel's main directory contains a space.
What's involved in fixing this properly? Make the whole kbuild
system operate correctly when there are spaces/colons in the
pathname?
next prev parent reply other threads:[~2016-07-26 0:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-24 13:28 Fabian Frederick
2016-07-26 0:05 ` Andrew Morton [this message]
2016-07-26 6:45 ` Robert Jarzmik
2016-07-26 21:47 ` Michal Marek
2016-07-27 14:37 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725170555.fd4df28de067f2a689a2efc2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome