From: Rich Felker <dalias@libc.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource: j-core: type fix init function return code
Date: Thu, 28 Jul 2016 03:02:45 -0400 [thread overview]
Message-ID: <20160728070245.GA25280@brightrain.aerifal.cx> (raw)
In-Reply-To: <3868635.g1oGrAbjGg@wuerfel>
On Wed, Jul 27, 2016 at 10:00:50AM +0200, Arnd Bergmann wrote:
> On Wednesday, July 27, 2016 1:25:33 AM CEST Rich Felker wrote:
> > On Tue, Jul 26, 2016 at 02:31:29PM +0200, Arnd Bergmann wrote:
> > > The CLOCKSOURCE_OF_DECLARE now takes a function that returns an 'int', but a this
> > > new clocksource driver has just appeared in linux-next and causes a warning because
> > > it has the old 'void' return value:
> > >
> > > In file included from ../include/linux/clocksource.h:18:0,
> > > from ../include/linux/clockchips.h:13,
> > > from ../drivers/clocksource/jcore-pit.c:14:
> > > include/linux/of.h:1006:20: error: comparison of distinct pointer types lacks a cast [-Werror]
> > > .data = (fn == (fn_type)NULL) ? fn : fn }
> > > ^
> > >
> > > This adapts the jcore_pit_init() function to the correct return type.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > Fixes: e0aa0655c60b ("clocksource: add J-Core timer/clocksource driver")
> > > ---
> > > The patch that introduces the warnign currently only exists in the linux-sh git
> > > tree and showed up in linux-next this week.
> >
> > I've removed the commit from my for-next branch since it's not
> > appropriate to go upstream through my tree. Your patch should still be
> > applied in the proper subsystem tree, though, I think. Daniel?
>
> I think the way to do it now is to fold my patch into your driver and submit
> it to the clocksource git on top of the API change.
Done.
Rich
prev parent reply other threads:[~2016-07-28 7:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 12:31 Arnd Bergmann
2016-07-27 5:25 ` Rich Felker
2016-07-27 8:00 ` Arnd Bergmann
2016-07-28 7:02 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728070245.GA25280@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®