From: Daniel Vetter <daniel@ffwll.ch>
To: Brian Starkey <brian.starkey@arm.com>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
seanpaul@chromium.org, Liviu Dudau <liviu.dudau@arm.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind()
Date: Thu, 28 Jul 2016 13:00:18 +0200 [thread overview]
Message-ID: <20160728110018.GK6232@phenom.ffwll.local> (raw)
In-Reply-To: <20160728082220.GA13322@e106950-lin.cambridge.arm.com>
On Thu, Jul 28, 2016 at 09:22:21AM +0100, Brian Starkey wrote:
> Hi Wei,
>
> On Thu, Jul 28, 2016 at 02:14:26AM +0000, Wei Yongjun wrote:
> > Fix to return error code -EINVAL from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port
> > instead of the endpoint')
> > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> > ---
>
> Thanks for cleaning up after me! :-)
>
> Acked-by: Brian Starkey <brian.starkey@arm.com>
Applied to drm-misc, thanks.
-Daniel
>
> @Sean, can you pick this up on top of 3c31760e760c?
>
> Cheers,
> Brian
>
> > drivers/gpu/drm/arm/malidp_drv.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> > index 4e61ea5..44b24cb 100644
> > --- a/drivers/gpu/drm/arm/malidp_drv.c
> > +++ b/drivers/gpu/drm/arm/malidp_drv.c
> > @@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev)
> >
> > /* Set the CRTC's port so that the encoder component can find it */
> > ep = of_graph_get_next_endpoint(dev->of_node, NULL);
> > - if (!ep)
> > + if (!ep) {
> > + ret = -EINVAL;
> > goto port_fail;
> > + }
> > malidp->crtc.port = of_get_next_parent(ep);
> >
> > ret = component_bind_all(dev, drm);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2016-07-28 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 2:14 Wei Yongjun
2016-07-28 8:22 ` Brian Starkey
2016-07-28 11:00 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728110018.GK6232@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=brian.starkey@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=seanpaul@chromium.org \
--cc=weiyj.lk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®