From: Mark Brown <broonie@kernel.org>
To: Maarten ter Huurne <maarten@treewalker.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: cache: Fix num_reg_defaults computation from reg_defaults_raw
Date: Fri, 29 Jul 2016 17:42:21 +0100 [thread overview]
Message-ID: <20160729164221.GK10376@sirena.org.uk> (raw)
In-Reply-To: <1469803603-15862-1-git-send-email-maarten@treewalker.org>
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On Fri, Jul 29, 2016 at 04:46:43PM +0200, Maarten ter Huurne wrote:
> for (count = 0, i = 0; i < map->num_reg_defaults_raw; i++)
> - if (!regmap_volatile(map, i * map->reg_stride))
> + if (regmap_readable(map, i * map->reg_stride) &&
> + !regmap_volatile(map, i * map->reg_stride))
This seems fine but please use a normal coding style, there's a *huge*
amount of indentation on the second line for some reason. It should
align with the ( in the if statement.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-29 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 14:46 Maarten ter Huurne
2016-07-29 16:42 ` Mark Brown [this message]
2016-07-29 21:42 ` [PATCH v2] " Maarten ter Huurne
2016-07-29 22:17 ` Applied "regmap: cache: Fix num_reg_defaults computation from reg_defaults_raw" to the regmap tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729164221.GK10376@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten@treewalker.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®