From: Mark Brown <broonie@kernel.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Jan Glauber <jglauber@cavium.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
David Daney <david.daney@cavium.com>,
"Steven J . Hill" <steven.hill@cavium.com>
Subject: Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver
Date: Mon, 1 Aug 2016 19:49:31 +0100 [thread overview]
Message-ID: <20160801184931.GB10376@sirena.org.uk> (raw)
In-Reply-To: <579F958F.9020508@caviumnetworks.com>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Mon, Aug 01, 2016 at 11:31:43AM -0700, David Daney wrote:
> On 08/01/2016 10:28 AM, Mark Brown wrote:
> > On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote:
> > > + p->clk = devm_clk_get(dev, NULL);
> > > + if (IS_ERR(p->clk))
> > > + goto out_unmap;
> > We're now just using the normal clock API which is good but I'm now
> > unclear what is going to ensure that the clock is there - is there some
> > other change elsewhere that I'm not aware of?
> The clock is an integral part of the SoC and is always running, so it will
> always be there. All we want to know is the frequency, which is supplied by
> the device tree clock-bindings framework
So there's something there that registers the clock? What is that thing
on ACPI systems?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-08-01 18:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 8:31 [PATCH v2 0/2] SPI ThunderX driver Jan Glauber
2016-07-28 8:31 ` [PATCH v2 1/2] spi: octeon: Split driver into Octeon specific and common parts Jan Glauber
2016-08-01 17:36 ` Mark Brown
2016-07-28 8:31 ` [PATCH v2 2/2] spi: octeon: Add thunderx driver Jan Glauber
2016-08-01 17:28 ` Mark Brown
2016-08-01 18:31 ` David Daney
2016-08-01 18:49 ` Mark Brown [this message]
2016-08-01 19:02 ` David Daney
2016-08-02 21:30 ` Mark Brown
2016-08-02 21:49 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801184931.GB10376@sirena.org.uk \
--to=broonie@kernel.org \
--cc=david.daney@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=jglauber@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®