* [PATCH 0216/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 10:50 Baole Ni
0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 10:50 UTC (permalink / raw)
To: jikos, benjamin.tissoires, thellstrom, airlied, kgene,
k.kozlowski, dougthompson, bp
Cc: linux-input, linux-kernel, chuansheng.liu, baolex.ni,
alexander.deucher, ville.syrjala
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/hid/hid-apple.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index 884d82f..a59441c 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -37,17 +37,17 @@
#define APPLE_FLAG_FKEY 0x01
static unsigned int fnmode = 1;
-module_param(fnmode, uint, 0644);
+module_param(fnmode, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(fnmode, "Mode of fn key on Apple keyboards (0 = disabled, "
"[1] = fkeyslast, 2 = fkeysfirst)");
static unsigned int iso_layout = 1;
-module_param(iso_layout, uint, 0644);
+module_param(iso_layout, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(iso_layout, "Enable/Disable hardcoded ISO-layout of the keyboard. "
"(0 = disabled, [1] = enabled)");
static unsigned int swap_opt_cmd;
-module_param(swap_opt_cmd, uint, 0644);
+module_param(swap_opt_cmd, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(swap_opt_cmd, "Swap the Option (\"Alt\") and Command (\"Flag\") keys. "
"(For people who want to keep Windows PC keyboard muscle memory. "
"[0] = as-is, Mac layout. 1 = swapped, Windows layout.)");
--
2.9.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-08-02 18:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 10:50 [PATCH 0216/1285] Replace numeric parameter like 0444 with macro Baole Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®