* [PATCH 0287/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 10:56 Baole Ni
0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 10:56 UTC (permalink / raw)
To: dmitry.torokhov, hal.rosenstock, dledford, sean.hefty, bp
Cc: linux-input, linux-kernel, rafael.j.wysocki, tiwai,
chuansheng.liu, baolex.ni
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/input/serio/i8042.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index 4541957..5177613 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -87,11 +87,11 @@ MODULE_PARM_DESC(nopnp, "Do not use PNP to detect controller settings");
#define DEBUG
#ifdef DEBUG
static bool i8042_debug;
-module_param_named(debug, i8042_debug, bool, 0600);
+module_param_named(debug, i8042_debug, bool, S_IRUSR | S_IWUSR);
MODULE_PARM_DESC(debug, "Turn i8042 debugging mode on and off");
static bool i8042_unmask_kbd_data;
-module_param_named(unmask_kbd_data, i8042_unmask_kbd_data, bool, 0600);
+module_param_named(unmask_kbd_data, i8042_unmask_kbd_data, bool, S_IRUSR | S_IWUSR);
MODULE_PARM_DESC(unmask_kbd_data, "Unconditional enable (may reveal sensitive data) of normally sanitize-filtered kbd data traffic debug log [pre-condition: i8042.debug=1 enabled]");
#endif
--
2.9.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-08-02 11:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 10:56 [PATCH 0287/1285] Replace numeric parameter like 0444 with macro Baole Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®