* [PATCH 0435/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:11 Baole Ni
2016-08-02 16:07 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Baole Ni @ 2016-08-02 11:11 UTC (permalink / raw)
To: mchehab, maurochehab, mchehab, mchehab, m.chehab, hverkuil, a.hajda, bp
Cc: linux-media, linux-kernel, javier, laurent.pinchart,
prabhakar.csengg, chuansheng.liu, baolex.ni
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/media/i2c/tvp5150.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 0b6d46c..d8ffd88 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -33,7 +33,7 @@ MODULE_LICENSE("GPL");
static int debug;
-module_param(debug, int, 0644);
+module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(debug, "Debug level (0-2)");
struct tvp5150 {
--
2.9.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 0435/1285] Replace numeric parameter like 0444 with macro
2016-08-02 11:11 [PATCH 0435/1285] Replace numeric parameter like 0444 with macro Baole Ni
@ 2016-08-02 16:07 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2016-08-02 16:07 UTC (permalink / raw)
To: Baole Ni, Greg KH
Cc: mchehab, maurochehab, mchehab, mchehab, Mauro Carvalho Chehab,
hverkuil, a.hajda, Borislav Petkov, linux-media, LKML, javier,
Laurent Pinchart, prabhakar.csengg, chuansheng.liu
There are so many of these, I wonder if it'd be better to just do one
giant patch, or at least break them up by subsystem instead of by
individual source file...
-Kees
On Tue, Aug 2, 2016 at 4:11 AM, Baole Ni <baolex.ni@intel.com> wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
> drivers/media/i2c/tvp5150.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index 0b6d46c..d8ffd88 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -33,7 +33,7 @@ MODULE_LICENSE("GPL");
>
>
> static int debug;
> -module_param(debug, int, 0644);
> +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
> MODULE_PARM_DESC(debug, "Debug level (0-2)");
>
> struct tvp5150 {
> --
> 2.9.2
>
--
Kees Cook
Chrome OS & Brillo Security
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:11 [PATCH 0435/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 16:07 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®