mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0500/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:18 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 11:18 UTC (permalink / raw)
  To: mchehab, maurochehab, mchehab, mchehab, m.chehab, awalls, a.hajda, bp
  Cc: linux-media, linux-kernel, chuansheng.liu, baolex.ni,
	jh1009.sung, nenggun.kim

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/pci/saa7134/saa7134-tvaudio.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/pci/saa7134/saa7134-tvaudio.c b/drivers/media/pci/saa7134/saa7134-tvaudio.c
index 38f94b7..ad6ed10a 100644
--- a/drivers/media/pci/saa7134/saa7134-tvaudio.c
+++ b/drivers/media/pci/saa7134/saa7134-tvaudio.c
@@ -35,18 +35,18 @@
 /* ------------------------------------------------------------------ */
 
 static unsigned int audio_debug;
-module_param(audio_debug, int, 0644);
+module_param(audio_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(audio_debug,"enable debug messages [tv audio]");
 
 static unsigned int audio_ddep;
-module_param(audio_ddep, int, 0644);
+module_param(audio_ddep, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(audio_ddep,"audio ddep overwrite");
 
 static int audio_clock_override = UNSET;
-module_param(audio_clock_override, int, 0644);
+module_param(audio_clock_override, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 static int audio_clock_tweak;
-module_param(audio_clock_tweak, int, 0644);
+module_param(audio_clock_tweak, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(audio_clock_tweak, "Audio clock tick fine tuning for cards with audio crystal that's slightly off (range [-1024 .. 1024])");
 
 #define audio_dbg(level, fmt, arg...) do { \
-- 
2.9.2

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 11:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:18 [PATCH 0500/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®