[PATCH 0505/1285] Replace numeric parameter like 0444 with macro

[PATCH 0505/1285] Replace numeric parameter like 0444 with macro

[Baole Ni]

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/pci/solo6x10/solo6x10-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/pci/solo6x10/solo6x10-core.c b/drivers/media/pci/solo6x10/solo6x10-core.c
index f50d072..d9acfc7 100644
--- a/drivers/media/pci/solo6x10/solo6x10-core.c
+++ b/drivers/media/pci/solo6x10/solo6x10-core.c
@@ -37,11 +37,11 @@ MODULE_VERSION(SOLO6X10_VERSION);
 MODULE_LICENSE("GPL");
 
 static unsigned video_nr = -1;
-module_param(video_nr, uint, 0644);
+module_param(video_nr, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(video_nr, "videoX start number, -1 is autodetect (default)");
 
 static int full_eeprom; /* default is only top 64B */
-module_param(full_eeprom, uint, 0644);
+module_param(full_eeprom, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(full_eeprom, "Allow access to full 128B EEPROM (dangerous)");
 
 
-- 
2.9.2

Re: [PATCH 0505/1285] Replace numeric parameter like 0444 with macro

[Ismael Luceno]

On 02/Ago/2016 19:18, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

That's very subjective; I don't agree.

IMO numbers are better in this context.