mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0549/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:23 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 11:23 UTC (permalink / raw)
  To: mchehab, maurochehab, mchehab, mchehab, m.chehab, hverkuil,
	s.nawrocki, kgene, k.kozlowski
  Cc: linux-media, linux-kernel, linux, chuansheng.liu, baolex.ni,
	niklas.soderlund+renesas

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/rc/ati_remote.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c
index 9f5b597..1930c33 100644
--- a/drivers/media/rc/ati_remote.c
+++ b/drivers/media/rc/ati_remote.c
@@ -128,23 +128,23 @@
 #define REPEAT_DELAY	500 /* msec */
 
 static unsigned long channel_mask;
-module_param(channel_mask, ulong, 0644);
+module_param(channel_mask, ulong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(channel_mask, "Bitmask of remote control channels to ignore");
 
 static int debug;
-module_param(debug, int, 0644);
+module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(debug, "Enable extra debug messages and information");
 
 static int repeat_filter = FILTER_TIME;
-module_param(repeat_filter, int, 0644);
+module_param(repeat_filter, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(repeat_filter, "Repeat filter time, default = 60 msec");
 
 static int repeat_delay = REPEAT_DELAY;
-module_param(repeat_delay, int, 0644);
+module_param(repeat_delay, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(repeat_delay, "Delay before sending repeats, default = 500 msec");
 
 static bool mouse = true;
-module_param(mouse, bool, 0444);
+module_param(mouse, bool, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(mouse, "Enable mouse device, default = yes");
 
 #define dbginfo(dev, format, arg...) \
-- 
2.9.2

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 16:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:23 [PATCH 0549/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®