mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0718/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:39 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 11:39 UTC (permalink / raw)
  To: tlfalcon, benh, paulus, mpe, computersforpeace, m.chehab, pawel,
	m.szyprowski, kyungmin.park, k.kozlowski
  Cc: netdev, linuxppc-dev, linux-kernel, chuansheng.liu, baolex.ni,
	fw, davem, Baohua.Song

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/net/ethernet/ibm/ibmveth.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index ebe6071..7b0fd24 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -66,17 +66,17 @@ MODULE_LICENSE("GPL");
 MODULE_VERSION(ibmveth_driver_version);
 
 static unsigned int tx_copybreak __read_mostly = 128;
-module_param(tx_copybreak, uint, 0644);
+module_param(tx_copybreak, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(tx_copybreak,
 	"Maximum size of packet that is copied to a new buffer on transmit");
 
 static unsigned int rx_copybreak __read_mostly = 128;
-module_param(rx_copybreak, uint, 0644);
+module_param(rx_copybreak, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(rx_copybreak,
 	"Maximum size of packet that is copied to a new buffer on receive");
 
 static unsigned int rx_flush __read_mostly = 0;
-module_param(rx_flush, uint, 0644);
+module_param(rx_flush, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(rx_flush, "Flush receive buffers before use");
 
 static bool old_large_send __read_mostly;
@@ -1730,9 +1730,9 @@ static ssize_t veth_pool_store(struct kobject *kobj, struct attribute *attr,
 	.name = __stringify(_name), .mode = _mode,	\
 	};
 
-static ATTR(active, 0644);
-static ATTR(num, 0644);
-static ATTR(size, 0644);
+static ATTR(active, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+static ATTR(num, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+static ATTR(size, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 static struct attribute *veth_pool_attrs[] = {
 	&veth_active_attr,
-- 
2.9.2

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 16:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:39 [PATCH 0718/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®