* [PATCH 0218/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 10:50 Baole Ni
2016-08-02 12:22 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Baole Ni @ 2016-08-02 10:50 UTC (permalink / raw)
To: jikos, benjamin.tissoires, thellstrom, airlied, kgene,
k.kozlowski, dougthompson, bp
Cc: linux-input, linux-kernel, chuansheng.liu, baolex.ni,
alexander.deucher, ville.syrjala
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/hid/hid-corsair.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-corsair.c b/drivers/hid/hid-corsair.c
index 717704e..5353847 100644
--- a/drivers/hid/hid-corsair.c
+++ b/drivers/hid/hid-corsair.c
@@ -370,8 +370,8 @@ static ssize_t k90_store_current_profile(struct device *dev,
return count;
}
-static DEVICE_ATTR(macro_mode, 0644, k90_show_macro_mode, k90_store_macro_mode);
-static DEVICE_ATTR(current_profile, 0644, k90_show_current_profile,
+static DEVICE_ATTR(macro_mode, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, k90_show_macro_mode, k90_store_macro_mode);
+static DEVICE_ATTR(current_profile, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, k90_show_current_profile,
k90_store_current_profile);
static struct attribute *k90_attrs[] = {
--
2.9.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 0218/1285] Replace numeric parameter like 0444 with macro
2016-08-02 10:50 [PATCH 0218/1285] Replace numeric parameter like 0444 with macro Baole Ni
@ 2016-08-02 12:22 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-08-02 12:22 UTC (permalink / raw)
To: Baole Ni
Cc: jikos, benjamin.tissoires, thellstrom, airlied, kgene,
k.kozlowski, dougthompson, bp, linux-input, linux-kernel,
chuansheng.liu, alexander.deucher, ville.syrjala
On Tue, Aug 02, 2016 at 06:50:39PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
> drivers/hid/hid-corsair.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-corsair.c b/drivers/hid/hid-corsair.c
> index 717704e..5353847 100644
> --- a/drivers/hid/hid-corsair.c
> +++ b/drivers/hid/hid-corsair.c
> @@ -370,8 +370,8 @@ static ssize_t k90_store_current_profile(struct device *dev,
> return count;
> }
>
> -static DEVICE_ATTR(macro_mode, 0644, k90_show_macro_mode, k90_store_macro_mode);
> -static DEVICE_ATTR(current_profile, 0644, k90_show_current_profile,
> +static DEVICE_ATTR(macro_mode, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, k90_show_macro_mode, k90_store_macro_mode);
> +static DEVICE_ATTR(current_profile, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, k90_show_current_profile,
> k90_store_current_profile);
DEVICE_ATTR_RW() please.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 10:50 [PATCH 0218/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 12:22 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®