* [PATCH 1169/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:22 Baole Ni
2016-08-02 13:29 ` Takashi Sakamoto
0 siblings, 1 reply; 2+ messages in thread
From: Baole Ni @ 2016-08-02 12:22 UTC (permalink / raw)
To: clemens, perex, tiwai, serge, davem, kadlec, m.szyprowski,
kyungmin.park, k.kozlowski
Cc: alsa-devel, linux-kernel, o-takashi, julia.lawall,
chuansheng.liu, baolex.ni, aryabinin
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
sound/firewire/bebob/bebob.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/firewire/bebob/bebob.c b/sound/firewire/bebob/bebob.c
index f7e2cbd..ec67fc6 100644
--- a/sound/firewire/bebob/bebob.c
+++ b/sound/firewire/bebob/bebob.c
@@ -22,11 +22,11 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX;
static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;
static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP;
-module_param_array(index, int, NULL, 0444);
+module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(index, "card index");
-module_param_array(id, charp, NULL, 0444);
+module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(id, "ID string");
-module_param_array(enable, bool, NULL, 0444);
+module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(enable, "enable BeBoB sound card");
static DEFINE_MUTEX(devices_mutex);
--
2.9.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1169/1285] Replace numeric parameter like 0444 with macro
2016-08-02 12:22 [PATCH 1169/1285] Replace numeric parameter like 0444 with macro Baole Ni
@ 2016-08-02 13:29 ` Takashi Sakamoto
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Sakamoto @ 2016-08-02 13:29 UTC (permalink / raw)
To: Baole Ni, clemens, perex, tiwai, serge, davem, kadlec,
m.szyprowski, kyungmin.park, k.kozlowski
Cc: alsa-devel, linux-kernel, julia.lawall, chuansheng.liu, aryabinin
On Aug 2 2016 21:22, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> sound/firewire/bebob/bebob.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/firewire/bebob/bebob.c b/sound/firewire/bebob/bebob.c
> index f7e2cbd..ec67fc6 100644
> --- a/sound/firewire/bebob/bebob.c
> +++ b/sound/firewire/bebob/bebob.c
> @@ -22,11 +22,11 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX;
> static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;
> static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP;
>
> -module_param_array(index, int, NULL, 0444);
> +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH);
> MODULE_PARM_DESC(index, "card index");
> -module_param_array(id, charp, NULL, 0444);
> +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH);
> MODULE_PARM_DESC(id, "ID string");
> -module_param_array(enable, bool, NULL, 0444);
> +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH);
> MODULE_PARM_DESC(enable, "enable BeBoB sound card");
>
> static DEFINE_MUTEX(devices_mutex);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 12:22 [PATCH 1169/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 13:29 ` Takashi Sakamoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®