From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Baole Ni <baolex.ni@intel.com>
Cc: <konrad.wilk@oracle.com>, <pavel@ucw.cz>,
<gregkh@linuxfoundation.org>, <hpa@zytor.com>, <x86@kernel.org>,
<xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>,
<chuansheng.liu@intel.com>, <martin.petersen@oracle.com>,
<kent.overstreet@gmail.com>
Subject: Re: [PATCH 0096/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 15:09:13 +0200 [thread overview]
Message-ID: <20160802130913.jncj2lteaie7mkep@mac> (raw)
In-Reply-To: <20160802104021.20157-1-baolex.ni@intel.com>
On Tue, Aug 02, 2016 at 06:40:21PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
prev parent reply other threads:[~2016-08-02 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:40 Baole Ni
2016-08-02 13:09 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802130913.jncj2lteaie7mkep@mac \
--to=roger.pau@citrix.com \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=kent.overstreet@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pavel@ucw.cz \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®