From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Baole Ni <baolex.ni@intel.com>
Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
Subject: Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 14:15:03 +0100 [thread overview]
Message-ID: <20160802141503.1e8d8796@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20160802103322.13810-1-baolex.ni@intel.com>
On Tue, 2 Aug 2016 18:33:22 +0800
Baole Ni <baolex.ni@intel.com> wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
If you are going to do this then please generate one patch per subsystem,
and just do a couple of subsystems initially until everyone is happy with
how it is being converted, then send out more subsystem by subsystem.
Alan
next prev parent reply other threads:[~2016-08-02 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:33 Baole Ni
2016-08-02 11:29 ` Russell King - ARM Linux
2016-08-02 13:15 ` One Thousand Gnomes [this message]
2016-08-02 15:08 ` Masami Hiramatsu
2016-08-02 17:42 ` Pavel Machek
2016-08-02 17:52 ` Joe Perches
2016-08-02 17:54 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802141503.1e8d8796@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®