mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: Oliver Neukum <oneukum@suse.com>,
	Geliang Tang <geliangtang@163.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
	"GeyslanG.Bem@Karyakshetra" <geyslan@gmail.com>,
	Masanari Iida <standby24x7@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Vlastimil Babka <vbabka@suse.cz>,
	Mel Gorman <mgorman@techsingularity.net>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	Saurabh Karajgaonkar <skarajga@visteon.com>
Subject: Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue
Date: Tue, 2 Aug 2016 23:26:50 +0200	[thread overview]
Message-ID: <20160802212650.GE11239@dhcp22.suse.cz> (raw)
In-Reply-To: <20160802190244.GH2542@mtj.duckdns.org>

On Tue 02-08-16 15:02:44, Tejun Heo wrote:
> Hello,
> 
> On Tue, Aug 02, 2016 at 03:29:48PM +0200, Oliver Neukum wrote:
> > Apparently if that is the requirement USB will have to define its own
> > set of flags to use in such contexts. But still the calls as currently
> > executed work. Taking away WQ_MEM_RECLAIM would create danger of
> > introducing a regression. The issue with __GFP_DIRECT_RECLAIM already
> > exists and can be fixed.
> 
> Alright, let's go with WQ_MEM_RECLAIM then.

Agreed, I would just add
/*
 * TODO: make sure that no work item in the rescuer can block on an
 * allocation (so no __GF_DIRECT_RECLAIM)
 */
to all work item functions.
-- 
Michal Hocko
SUSE Labs

      reply	other threads:[~2016-08-02 21:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27  9:20 Bhaktipriya Shridhar
2016-07-27  9:29 ` Oliver Neukum
2016-07-27 18:00   ` Tejun Heo
2016-07-27 18:54     ` Alan Stern
2016-07-27 19:23       ` Tejun Heo
2016-07-27 20:45         ` Alan Stern
2016-07-29 13:11           ` Tejun Heo
2016-08-01 13:50             ` Michal Hocko
2016-08-01 14:20               ` Tejun Heo
2016-08-01 18:00                 ` Alan Stern
2016-08-01 18:28                   ` Michal Hocko
2016-08-02  8:06                 ` Oliver Neukum
2016-08-02  8:18                   ` Michal Hocko
2016-08-02 10:03                     ` Oliver Neukum
2016-08-02 11:34                       ` Michal Hocko
2016-08-02 11:44                         ` Oliver Neukum
2016-08-02 12:48                           ` Michal Hocko
2016-08-02 13:29                             ` Oliver Neukum
2016-08-02 19:02                               ` Tejun Heo
2016-08-02 21:26                                 ` Michal Hocko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802212650.GE11239@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=bhaktipriya96@gmail.com \
    --cc=geliangtang@163.com \
    --cc=geyslan@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mgorman@techsingularity.net \
    --cc=oneukum@suse.com \
    --cc=skarajga@visteon.com \
    --cc=standby24x7@gmail.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tj@kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®