From: Mark Brown <broonie@kernel.org>
To: Cristian Birsan <cristian.birsan@microchip.com>
Cc: nicolas.ferre@atmel.com, ludovic.desroches@atmel.com,
alexandre.belloni@free-electrons.com,
boris.brezillon@free-electrons.com, ce3a@gmx.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regmap: Add a function to check if a regmap register is cached
Date: Thu, 4 Aug 2016 16:48:14 +0100 [thread overview]
Message-ID: <20160804154814.GA10383@sirena.org.uk> (raw)
In-Reply-To: <1470322558-7501-2-git-send-email-cristian.birsan@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Thu, Aug 04, 2016 at 05:55:57PM +0300, Cristian Birsan wrote:
> +bool regmap_cached(struct regmap *map, unsigned int reg)
> +{
> + if (map->cache == REGCACHE_NONE)
> + return false;
> +
> + if (!map->cache_ops)
> + return false;
> +
> + if (map->max_register && reg > map->max_register)
> + return false;
> +
> + return true;
> +}
As Lars said this isn't actually checking if the register is cached. To
do this you need to modify the output code to check if there's a value
cached and try a read if there is one instead.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-08-04 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 14:55 [PATCH 0/2] Display regmap values in debugfs for write only registers Cristian Birsan
2016-08-04 14:55 ` [PATCH 1/2] regmap: Add a function to check if a regmap register is cached Cristian Birsan
2016-08-04 15:39 ` Lars-Peter Clausen
2016-08-04 15:48 ` Mark Brown [this message]
2016-08-08 15:44 ` [PATCH v2 0/2] Display regmap values in debugfs for write only registers Cristian Birsan
2016-08-08 15:44 ` [PATCH v2 1/2] regmap: Add a function to check if a regmap register is cached Cristian Birsan
2016-08-09 12:44 ` Applied "regmap: Add a function to check if a regmap register is cached" to the regmap tree Mark Brown
2016-08-08 15:44 ` [PATCH v2 2/2] regmap: debugfs: Add support for dumping write only device registers Cristian Birsan
2016-08-09 12:44 ` Applied "regmap: debugfs: Add support for dumping write only device registers" to the regmap tree Mark Brown
2016-08-09 13:11 ` kbuild test robot
2016-08-09 13:18 ` kbuild test robot
2016-08-10 12:15 ` Cristian Birsan
2016-08-04 14:55 ` [PATCH 2/2] regmap: debugfs: Add support for dumping write only device registers Cristian Birsan
2016-08-04 20:26 ` Mark Brown
2016-08-05 8:26 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804154814.GA10383@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=ce3a@gmx.de \
--cc=cristian.birsan@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome