From: Greg KH <gregkh@linuxfoundation.org>
To: dirk.eibach@gdsys.cc
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
jslaby@suse.com, jringle@gridpoint.com
Subject: Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop
Date: Mon, 8 Aug 2016 15:43:15 +0200 [thread overview]
Message-ID: <20160808134315.GA11190@kroah.com> (raw)
In-Reply-To: <1470663136-26269-1-git-send-email-dirk.eibach@gdsys.cc>
On Mon, Aug 08, 2016 at 03:32:15PM +0200, dirk.eibach@gdsys.cc wrote:
> From: Dirk Eibach <dirk.eibach@gdsys.cc>
>
> sc16is7xx_port_irq() is laid out as an endless loop. It will exit only
> when there is no more interrupt left to service. This not common
> practice.
> In our case it lead to some strange hangup situation when there was an
> unexpected XOFF-interrupt that could not be handled.
> So let's service interrupts only once and report XOFF-interrupts that
> should never happen since they are never enabled.
>
> Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
>
> Conflicts:
> drivers/tty/serial/sc16is7xx.c
Why are these 2 lines in here?
next prev parent reply other threads:[~2016-08-08 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 13:32 dirk.eibach
2016-08-08 13:32 ` [PATCH 2/2] sc16is7xx: Disable regmap cache dirk.eibach
2016-08-08 13:43 ` Greg KH [this message]
2016-08-08 14:02 ` [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop Dirk Eibach
2016-08-09 8:52 ` m.brock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808134315.GA11190@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dirk.eibach@gdsys.cc \
--cc=jringle@gridpoint.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®