From: Jason Cooper <jason@lakedaemon.net>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
Cc: monstr@monstr.eu, ralf@linux-mips.org, tglx@linutronix.de,
marc.zyngier@arm.com, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip
Date: Mon, 15 Aug 2016 15:22:50 +0000 [thread overview]
Message-ID: <20160815152250.GE3353@io.lakedaemon.net> (raw)
In-Reply-To: <1471269335-58747-2-git-send-email-Zubair.Kakakhel@imgtec.com>
Hi Zubair,
On Mon, Aug 15, 2016 at 02:55:27PM +0100, Zubair Lutfullah Kakakhel wrote:
> The Xilinx AXI Interrupt Controller IP block is used by the MIPS
> based xilfpga platform.
>
> Move the interrupt controller code out of arch/microblaze so that
> it can be used by everyone
>
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
> ---
> arch/microblaze/Kconfig | 1 +
> arch/microblaze/kernel/Makefile | 2 +-
> drivers/irqchip/Kconfig | 4 ++++
> drivers/irqchip/Makefile | 1 +
> arch/microblaze/kernel/intc.c => drivers/irqchip/irq-xilinx.c | 0
> 5 files changed, 7 insertions(+), 1 deletion(-)
> rename arch/microblaze/kernel/intc.c => drivers/irqchip/irq-xilinx.c (100%)
When you send the next version, please disable rename detection. The
driver looks pretty straight forward, but I'd like to take the
opportunity to clean up the abstraction around read and write. As well
as making it easier for everyone to review on-list.
thx,
Jason.
next prev parent reply other threads:[~2016-08-15 15:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 13:55 [PATCH 0/9] MIPS: xilfpga: Intc and various peripherals Zubair Lutfullah Kakakhel
2016-08-15 13:55 ` [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip Zubair Lutfullah Kakakhel
2016-08-15 15:06 ` Jason Cooper
2016-08-15 15:22 ` Jason Cooper [this message]
2016-08-18 9:59 ` Zubair Lutfullah Kakakhel
2016-08-15 13:55 ` [PATCH 2/9] irqchip: xilinx: Add support for parent intc Zubair Lutfullah Kakakhel
2016-08-15 13:55 ` [PATCH 3/9] MIPS: xilfpga: Use irqchip_init instead of the legacy way Zubair Lutfullah Kakakhel
2016-08-15 13:55 ` [PATCH 4/9] MIPS: xilfpga: Use Xilinx AXI Interrupt Controller Zubair Lutfullah Kakakhel
2016-08-15 15:12 ` Jason Cooper
2016-08-15 13:55 ` [PATCH 5/9] MIPS: xilfpga: Update DT node and specify uart irq Zubair Lutfullah Kakakhel
2016-08-15 13:55 ` [PATCH 6/9] MIPS: Xilfpga: Add DT node for AXI I2C Zubair Lutfullah Kakakhel
2016-08-15 13:55 ` [PATCH 7/9] net: ethernet: xilinx: Enable emaclite for MIPS Zubair Lutfullah Kakakhel
2016-08-15 13:55 ` [PATCH 8/9] MIPS: xilfpga: Add DT node for AXI emaclite Zubair Lutfullah Kakakhel
2016-08-15 15:17 ` Jason Cooper
2016-08-18 10:01 ` Zubair Lutfullah Kakakhel
2016-08-15 13:55 ` [PATCH 9/9] MIPS: xilfpga: Update defconfig Zubair Lutfullah Kakakhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815152250.GE3353@io.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=marc.zyngier@arm.com \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome