From: Andrew Lunn <andrew@lunn.ch>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>,
David Miller <davem@davemloft.net>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
appanad@xilinx.com, f.fainelli@gmail.com, punnaia@xilinx.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support
Date: Mon, 15 Aug 2016 23:30:59 +0200 [thread overview]
Message-ID: <20160815213059.GK24664@lunn.ch> (raw)
In-Reply-To: <1470735283-23611-4-git-send-email-appanad@xilinx.com>
> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
> ---
> Thanks a lot Andrew for your inputs.
> Changes for v5:
> --> Fixed return values in the probe as suggested by punnaiah.
> --> Added a mask for the converter speed as suggested by punnaiah.
> +/* Xilinx GMII2RGMII Converter driver
> + *
> + * Copyright (C) 2016 Xilinx, Inc.
> + *
> + * Author: Kedareswara rao Appana <appanad@xilinx.com>
Not cool
https://github.com/lunn/linux/commit/03d375489ceb56e171056f44d0fe9c34ca5a098e
Notice the
Not-Signed-off-by: Andrew Lunn <andrew@lunn.ch>
and the Copyright i added?
In various emails i gave you the basic idea how this should be done, a
framework of code, and then took your code which did not even compile
and made the core of it work. This is as much my code as your code, so
i expect my Copyright to be kept on this code. And since this is my
code, i need to give a Signed-off-by, which i was not yet ready to
give since the code was not complete or working.
Please put both my Copyright back and Not-Signed-Off-by back and post
the next version as RFC. Once i'm happy this code is O.K, i will give
you a Signed-off-by.
Andrew
next prev parent reply other threads:[~2016-08-15 21:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 9:34 [RFC PATCH v5 0/3] net: phy: Add xilinx " Kedareswara rao Appana
2016-08-09 9:34 ` [RFC PATCH v5 1/3] net: Add mask for Control register 10Mbps speed Kedareswara rao Appana
2016-08-09 21:41 ` Florian Fainelli
2016-08-09 9:34 ` [RFC PATCH v5 2/3] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation Kedareswara rao Appana
2016-08-09 21:50 ` Florian Fainelli
2016-08-10 5:31 ` Appana Durga Kedareswara Rao
2016-08-09 9:34 ` [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support Kedareswara rao Appana
2016-08-09 21:29 ` Florian Fainelli
2016-08-10 5:27 ` Appana Durga Kedareswara Rao
2016-08-15 21:30 ` Andrew Lunn [this message]
2016-08-16 6:30 ` Appana Durga Kedareswara Rao
2016-08-16 16:09 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815213059.GK24664@lunn.ch \
--to=andrew@lunn.ch \
--cc=appana.durga.rao@xilinx.com \
--cc=appanad@xilinx.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=punnaia@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®