From: Darren Hart <dvhart@infradead.org>
To: Peter Feuerer <peter@piie.net>
Cc: Baole Ni <baolex.ni@intel.com>,
david.vrabel@citrix.com, jgross@suse.com, bhelgaas@google.com,
m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com,
kyungmin.park@samsung.com, k.kozlowski@samsung.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
Subject: Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with macro
Date: Fri, 19 Aug 2016 13:02:32 -0700 [thread overview]
Message-ID: <20160819200232.GE81374@f23x64.localdomain> (raw)
In-Reply-To: <95991cb563633df910245c1fa8d83169@mail.piie.net>
On Thu, Aug 11, 2016 at 09:21:48PM +0000, Peter Feuerer wrote:
> 2. August 2016 14:29 Uhr, "Baole Ni" <baolex.ni@intel.com> schrieb:
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
> >
> > Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> > Signed-off-by: Baole Ni <baolex.ni@intel.com>
>
> Acked-by: Peter Feuerer <peter@piie.net>
Due to objections elsewhere in the platform drivers subsystem, I have rejected
these patches as a group, leaving it to the authors to make the argument for
inclusion if they disagree with the decision.
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2016-08-19 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 11:51 Baole Ni
2016-08-11 21:21 ` Peter Feuerer
2016-08-19 20:02 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160819200232.GE81374@f23x64.localdomain \
--to=dvhart@infradead.org \
--cc=baolex.ni@intel.com \
--cc=bhelgaas@google.com \
--cc=chuansheng.liu@intel.com \
--cc=david.vrabel@citrix.com \
--cc=jgross@suse.com \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=pawel@osciak.com \
--cc=peter@piie.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®