From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: dingxiang <dingxiang@huawei.com>
Cc: arnaud.patard@rtp-net.org, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:xgifb:remove unused code
Date: Tue, 23 Aug 2016 13:37:00 +0530 [thread overview]
Message-ID: <20160823080700.GA9280@sudip-laptop> (raw)
In-Reply-To: <57BBFABA.9070300@huawei.com>
On Tue, Aug 23, 2016 at 03:26:50PM +0800, dingxiang wrote:
> The variable data is assigned but never used in rest code.
>
> Signed-off-by: Ding Xiang <dingxiang@huawei.com>
> ---
Your name in Signed-off-by: and From: doesnot match.
> drivers/staging/xgifb/vb_setmode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 50c8ea4..71bb9ca 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex,
> tempax |= 0x40;
> xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax);
> - data = xgifb_reg_get(pVBInfo->P3d4, 0x07);
> tempax = 0;
> if (tempbx & 0x04)
The patch will not apply. Its missing two blank lines which the original
code has.
regards
sudip
prev parent reply other threads:[~2016-08-23 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1471936942-15631-1-git-send-email-dingxiang@huawei.com>
2016-08-23 7:26 ` dingxiang
2016-08-23 8:07 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823080700.GA9280@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=arnaud.patard@rtp-net.org \
--cc=devel@driverdev.osuosl.org \
--cc=dingxiang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®