From: Dmitry Safonov <dsafonov@virtuozzo.com>
To: <linux-kernel@vger.kernel.org>, <mingo@redhat.com>
Cc: <luto@amacapital.net>, <tglx@linutronix.de>, <hpa@zytor.com>,
<x86@kernel.org>, <0x7f454c46@gmail.com>, <oleg@redhat.com>,
<rostedt@goodmis.org>, <viro@zeniv.linux.org.uk>,
Dmitry Safonov <dsafonov@virtuozzo.com>
Subject: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe
Date: Thu, 25 Aug 2016 18:21:09 +0300 [thread overview]
Message-ID: <20160825152110.25663-3-dsafonov@virtuozzo.com> (raw)
In-Reply-To: <20160825152110.25663-1-dsafonov@virtuozzo.com>
It's useless. Before:
[tracing]# echo 'p:test /a:0x0' >> uprobe_events
[tracing]# echo 'p:test a:0x0' >> uprobe_events
-bash: echo: write error: No such file or directory
[tracing]# echo 'p:test 1:0x0' >> uprobe_events
-bash: echo: write error: Invalid argument
After:
[tracing]# echo 'p:test 1:0x0' >> uprobe_events
-bash: echo: write error: No such file or directory
Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
---
kernel/trace/trace_uprobe.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index c53485441c88..a74f2d9ff379 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -427,10 +427,6 @@ static int create_trace_uprobe(int argc, char **argv)
pr_info("Probe point is not specified.\n");
return -EINVAL;
}
- if (isdigit(argv[1][0])) {
- pr_info("probe point must be have a filename.\n");
- return -EINVAL;
- }
arg = strchr(argv[1], ':');
if (!arg) {
ret = -EINVAL;
--
2.9.0
next prev parent reply other threads:[~2016-08-25 16:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 15:21 [RFC 0/3] Put vdso in ramfs-like filesystem (vdsofs) Dmitry Safonov
2016-08-25 15:21 ` [RFC 1/3] x86/vdso: create vdso file, use it for mapping Dmitry Safonov
2016-08-25 19:49 ` Dmitry Safonov
2016-08-25 20:05 ` Dmitry Safonov
2016-08-28 20:14 ` Cyrill Gorcunov
2016-08-29 9:18 ` Dmitry Safonov
2016-08-29 9:28 ` Andy Lutomirski
2016-08-29 9:50 ` Dmitry Safonov
2016-08-30 14:58 ` Andy Lutomirski
2016-09-03 0:08 ` Al Viro
2016-08-30 14:33 ` Oleg Nesterov
2016-08-30 14:53 ` Dmitry Safonov
2016-09-03 0:13 ` Al Viro
2016-09-03 0:20 ` Al Viro
2016-09-03 7:32 ` Dmitry Safonov
2016-08-25 15:21 ` Dmitry Safonov [this message]
2016-08-29 22:58 ` [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe Steven Rostedt
2016-08-29 22:59 ` Steven Rostedt
2016-08-29 23:01 ` Dmitry Safonov
2016-08-30 14:37 ` Oleg Nesterov
2016-08-30 21:15 ` Steven Rostedt
2016-08-31 12:07 ` Oleg Nesterov
2016-08-30 14:57 ` Srikar Dronamraju
2016-08-25 15:21 ` [RFC 3/3] uprobe: add vdso support Dmitry Safonov
2016-08-25 20:49 ` [RFC 0/3] Put vdso in ramfs-like filesystem (vdsofs) H. Peter Anvin
2016-08-25 22:53 ` Dmitry Safonov
2016-08-25 23:00 ` H. Peter Anvin
2016-08-26 11:16 ` Dmitry Safonov
2016-08-26 14:32 ` Andy Lutomirski
2016-08-26 14:42 ` Dmitry Safonov
2016-08-26 14:44 ` Dmitry Safonov
2016-09-21 0:22 ` H. Peter Anvin
2016-09-21 0:32 ` H. Peter Anvin
2016-09-21 0:54 ` Andy Lutomirski
2016-09-21 1:07 ` H. Peter Anvin
2016-09-21 1:17 ` H. Peter Anvin
2016-09-21 6:39 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825152110.25663-3-dsafonov@virtuozzo.com \
--to=dsafonov@virtuozzo.com \
--cc=0x7f454c46@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome