* [PATCH] toshiba_acpi: Fix the kbd_backlight_mode_show printed value
@ 2016-08-16 18:07 Azael Avalos
2016-08-28 17:06 ` Darren Hart
0 siblings, 1 reply; 2+ messages in thread
From: Azael Avalos @ 2016-08-16 18:07 UTC (permalink / raw)
To: Darren Hart, platform-driver-x86, linux-kernel; +Cc: Azael Avalos
The mentioned function prints the value in decimal, but the
documentation and its parent function available_kbd_modes_show
are showing the value as hexadecimal.
This patch simply changes the value printed from decimal to hex,
as stated in the documentation and the parent function.
Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index 254a4d5..444f351 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -1873,7 +1873,7 @@ static ssize_t kbd_backlight_mode_show(struct device *dev,
if (toshiba_kbd_illum_status_get(toshiba, &time) < 0)
return -EIO;
- return sprintf(buf, "%i\n", time & SCI_KBD_MODE_MASK);
+ return sprintf(buf, "0x%x\n", time & SCI_KBD_MODE_MASK);
}
static DEVICE_ATTR_RW(kbd_backlight_mode);
--
2.9.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] toshiba_acpi: Fix the kbd_backlight_mode_show printed value
2016-08-16 18:07 [PATCH] toshiba_acpi: Fix the kbd_backlight_mode_show printed value Azael Avalos
@ 2016-08-28 17:06 ` Darren Hart
0 siblings, 0 replies; 2+ messages in thread
From: Darren Hart @ 2016-08-28 17:06 UTC (permalink / raw)
To: Azael Avalos; +Cc: platform-driver-x86, linux-kernel
On Tue, Aug 16, 2016 at 12:07:55PM -0600, Azael Avalos wrote:
> The mentioned function prints the value in decimal, but the
> documentation and its parent function available_kbd_modes_show
> are showing the value as hexadecimal.
>
> This patch simply changes the value printed from decimal to hex,
> as stated in the documentation and the parent function.
>
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
Thanks, Queued to for-next.
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-28 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-16 18:07 [PATCH] toshiba_acpi: Fix the kbd_backlight_mode_show printed value Azael Avalos
2016-08-28 17:06 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®