mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-pm@vger.kernel.org, Wang Wilbur <wilburwang@asrmicro.com>,
	Wu Gang <gangwu@asrmicro.com>,
	linux-kernel@vger.kernel.org, qiaozhou <qiaozhou@asrmicro.com>
Subject: [PATCH] power: avoid calling cancel_delayed_work_sync() during early boot
Date: Mon, 5 Sep 2016 08:38:13 -0400	[thread overview]
Message-ID: <20160905123813.GB20784@mtj.duckdns.org> (raw)
In-Reply-To: <c8aca802-e681-8bc3-4ebc-e86cd9b7e2f4@asrmicro.com>

of_clk_init() ends up calling into pm_qos_update_request() very early
during boot where irq is expected to stay disabled.
pm_qos_update_request() uses cancel_delayed_work_sync() which
correctly assumes that irq is enabled on invocation and
unconditionally disables and re-enables it.

Gate cancel_delayed_work_sync() invocation with kevented_up() to avoid
enabling irq unexpectedly during early boot.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-and-tested-by: Qiao Zhou <qiaozhou@asrmicro.com>
Link: http://lkml.kernel.org/r/d2501c4c-8e7b-bea3-1b01-000b36b5dfe9@asrmicro.com
---

Rafael, can you please route this patch?

Thanks.

 kernel/power/qos.c |   11 ++++++++++-
  1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/kernel/power/qos.c b/kernel/power/qos.c
index 97b0df7..168ff44 100644
--- a/kernel/power/qos.c
+++ b/kernel/power/qos.c
@@ -482,7 +482,16 @@ void pm_qos_update_request(struct pm_qos_request *req,
 		return;
 	}
 
-	cancel_delayed_work_sync(&req->work);
+	/*
+	 * This function may be called very early during boot, for example,
+	 * from of_clk_init(), where irq needs to stay disabled.
+	 * cancel_delayed_work_sync() assumes that irq is enabled on
+	 * invocation and re-enables it on return.  Avoid calling it until
+	 * workqueue is initialized.
+	 */
+	if (keventd_up())
+		cancel_delayed_work_sync(&req->work);
+
 	__pm_qos_update_request(req, new_value);
 }
 EXPORT_SYMBOL_GPL(pm_qos_update_request);

  reply	other threads:[~2016-09-05 12:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01  9:09 [Question] about patch: don't use [delayed_]work_pending() qiaozhou
2016-09-01 18:45 ` Tejun Heo
2016-09-02  1:17   ` qiaozhou
2016-09-02 13:50     ` Tejun Heo
2016-09-02 14:21       ` Tejun Heo
2016-09-03 15:27         ` qiaozhou
2016-09-05  5:34         ` qiaozhou
2016-09-05 12:38           ` Tejun Heo [this message]
2016-09-05 12:58             ` [PATCH] power: avoid calling cancel_delayed_work_sync() during early boot Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160905123813.GB20784@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=gangwu@asrmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=qiaozhou@asrmicro.com \
    --cc=rjw@rjwysocki.net \
    --cc=wilburwang@asrmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®