From: Jan Kara <jack@suse.cz>
To: Eric Ren <zren@suse.com>
Cc: Geliang Tang <geliangtang@gmail.com>,
"Theodore Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jbd2: add jbd2_journal_init() helper
Date: Tue, 6 Sep 2016 17:15:54 +0200 [thread overview]
Message-ID: <20160906151554.GK28922@quack2.suse.cz> (raw)
In-Reply-To: <1b8c6456-dcf2-648d-2a29-6671fc519187@suse.com>
On Sat 03-09-16 17:33:39, Eric Ren wrote:
> Hi Geliang,
>
> On 08/31/2016 08:23 PM, Geliang Tang wrote:
> >There are some repetitive code in jbd2_journal_init_dev() and
> >jbd2_journal_init_inode(). So this patch extracts the common code into
> >jbd2_journal_init() helper to simplify the code. And fix the coding
> >style warnings reported by checkpatch.pl by the way.
> journal_init_common() is already there for the same purpose, right?
> Do we really need another helper?
Agreed, just move the common code into journal_init_common(). Also the
__getblk() in jbd2_journal_init_dev() should be getblk_unmovable() so that
would be a good preparatory fix to remove the need of the gfp argument.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2016-09-06 15:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 12:23 Geliang Tang
2016-09-03 9:33 ` Eric Ren
2016-09-06 15:15 ` Jan Kara [this message]
2016-09-07 12:41 ` [PATCH] " Geliang Tang
2016-09-07 12:41 ` [PATCH] jbd2: move more common code into journal_init_common() Geliang Tang
2016-09-07 13:16 ` Jan Kara
2016-09-15 16:03 ` Theodore Ts'o
2016-09-15 19:58 ` Theodore Ts'o
2016-09-18 2:39 ` Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906151554.GK28922@quack2.suse.cz \
--to=jack@suse.cz \
--cc=geliangtang@gmail.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=zren@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®