[tip:smp/hotplug 15/27] kernel/cpu.c:1282:3: error: 'CPUHP_SLAB_PREPARE' undeclared here (not in a function)

[tip:smp/hotplug 15/27] kernel/cpu.c:1282:3: error: 'CPUHP_SLAB_PREPARE' undeclared here (not in a function)

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3584 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp/hotplug
head:   712251665c8b6ff95fd27876338c2543d8fb5bc8
commit: e37b94bdb19a66c1164b0916c648da15c44ff39a [15/27] slab: Convert to hotplug state machine
config: i386-randconfig-s0-201636 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        git checkout e37b94bdb19a66c1164b0916c648da15c44ff39a
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   kernel/cpu.c:1277:26: warning: missing braces around initializer [-Wmissing-braces]
     [CPUHP_RELAY_PREPARE] = {
                             ^
   kernel/cpu.c:1277:26: note: (near initialization for 'cpuhp_bp_states[19]')
>> kernel/cpu.c:1282:3: error: 'CPUHP_SLAB_PREPARE' undeclared here (not in a function)
     [CPUHP_SLAB_PREPARE] = {
      ^~~~~~~~~~~~~~~~~~
>> kernel/cpu.c:1282:3: error: array index in initializer not of integer type
   kernel/cpu.c:1282:3: note: (near initialization for 'cpuhp_bp_states')
   kernel/cpu.c:1282:25: warning: missing braces around initializer [-Wmissing-braces]
     [CPUHP_SLAB_PREPARE] = {
                            ^
   kernel/cpu.c:1282:25: note: (near initialization for 'cpuhp_bp_states[20]')
   kernel/cpu.c:1287:25: warning: missing braces around initializer [-Wmissing-braces]
     [CPUHP_RCUTREE_PREP] = {
                            ^
   kernel/cpu.c:1287:25: note: (near initialization for 'cpuhp_bp_states[20]')
   kernel/cpu.c:1296:27: warning: missing braces around initializer [-Wmissing-braces]
     [CPUHP_NOTIFY_PREPARE] = {
                              ^
   kernel/cpu.c:1296:27: note: (near initialization for 'cpuhp_bp_states[21]')
   kernel/cpu.c:1308:24: warning: missing braces around initializer [-Wmissing-braces]
     [CPUHP_TIMERS_DEAD] = {
                           ^
   kernel/cpu.c:1308:24: note: (near initialization for 'cpuhp_bp_states[22]')
   kernel/cpu.c:1314:24: warning: missing braces around initializer [-Wmissing-braces]
     [CPUHP_BRINGUP_CPU] = {
                           ^
   kernel/cpu.c:1314:24: note: (near initialization for 'cpuhp_bp_states[23]')
   kernel/cpu.c:1320:28: warning: missing braces around initializer [-Wmissing-braces]
     [CPUHP_AP_SMPCFD_DYING] = {
                               ^
   kernel/cpu.c:1320:28: note: (near initialization for 'cpuhp_bp_states[66]')
   kernel/cpu.c:1329:25: warning: missing braces around initializer [-Wmissing-braces]
     [CPUHP_TEARDOWN_CPU] = {
                            ^
   kernel/cpu.c:1329:25: note: (near initialization for 'cpuhp_bp_states[69]')
   kernel/cpu.c:1244:46: warning: missing braces around initializer [-Wmissing-braces]
    static struct cpuhp_step cpuhp_bp_states[] = {
                                                 ^
   kernel/cpu.c:1244:46: note: (near initialization for 'cpuhp_bp_states')

vim +/CPUHP_SLAB_PREPARE +1282 kernel/cpu.c

  1271		},
  1272		[CPUHP_SMPCFD_PREPARE] = {
  1273			.name			= "smpcfd:prepare",
  1274			.startup.single		= smpcfd_prepare_cpu,
  1275			.teardown.single	= smpcfd_dead_cpu,
  1276		},
> 1277		[CPUHP_RELAY_PREPARE] = {
  1278			.name			= "relay:prepare",
  1279			.startup		= relay_prepare_cpu,
  1280			.teardown		= NULL,
  1281		},
> 1282		[CPUHP_SLAB_PREPARE] = {
  1283			.name			= "slab:prepare",
  1284			.startup		= slab_prepare_cpu,
  1285			.teardown		= slab_dead_cpu,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 22126 bytes --]

Re: [tip:smp/hotplug 15/27] kernel/cpu.c:1282:3: error: 'CPUHP_SLAB_PREPARE' undeclared here (not in a function)

[Sebastian Andrzej Siewior]

On 2016-09-07 00:08:04 [+0800], kbuild test robot wrote:
>    kernel/cpu.c:1277:26: note: (near initialization for 'cpuhp_bp_states[19]')
> >> kernel/cpu.c:1282:3: error: 'CPUHP_SLAB_PREPARE' undeclared here (not in a function)
>      [CPUHP_SLAB_PREPARE] = {
>       ^~~~~~~~~~~~~~~~~~

The
    include/linux/cpuhotplug.h |   1 +

went missing from the original patch.

Sebastian

Re: [tip:smp/hotplug 15/27] kernel/cpu.c:1282:3: error: 'CPUHP_SLAB_PREPARE' undeclared here (not in a function)

[Thomas Gleixner]

On Tue, 6 Sep 2016, Sebastian Andrzej Siewior wrote:

> On 2016-09-07 00:08:04 [+0800], kbuild test robot wrote:
> >    kernel/cpu.c:1277:26: note: (near initialization for 'cpuhp_bp_states[19]')
> > >> kernel/cpu.c:1282:3: error: 'CPUHP_SLAB_PREPARE' undeclared here (not in a function)
> >      [CPUHP_SLAB_PREPARE] = {
> >       ^~~~~~~~~~~~~~~~~~
> 
> The
>     include/linux/cpuhotplug.h |   1 +

Indeed. And I did not notice because it compiled with CONFIG_SMP=n. Duh!