From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: cppi41: mark PM functions as __maybe_unused
Date: Wed, 7 Sep 2016 12:56:10 -0700 [thread overview]
Message-ID: <20160907195610.4em7ykm3m7sb6ldh@atomide.com> (raw)
In-Reply-To: <20160906132030.2014181-1-arnd@arndb.de>
* Arnd Bergmann <arnd@arndb.de> [160906 06:20]:
> When CONFIG_PM_SLEEP is disabled, we get a build error in
> the cppi41 dmaengine driver, since the runtime-pm functions
> are hidden within the wrong #ifdef:
>
> drivers/dma/cppi41.c:1158:21: error: 'cppi41_runtime_suspend' undeclared here (not in a function)
>
> This removes the #ifdef and instead uses __maybe_unused
> annotations that cannot have this problem.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support")
Thanks for fixing it:
Acked-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2016-09-07 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 13:20 Arnd Bergmann
2016-09-07 19:56 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907195610.4em7ykm3m7sb6ldh@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®