From: Eric Engestrom <eric.engestrom@imgtec.com>
To: <linux-kernel@vger.kernel.org>
Cc: Eric Engestrom <eric.engestrom@imgtec.com>,
Jeff Moyer <jmoyer@redhat.com>, Jens Axboe <axboe@fb.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Dan Williams <dan.j.williams@intel.com>,
Ming Lin <ming.l@ssi.samsung.com>,
Mike Christie <mchristi@redhat.com>
Subject: [PATCH v2] skd: fix assert typo
Date: Fri, 16 Sep 2016 10:31:23 +0100 [thread overview]
Message-ID: <20160916093125.14322-1-eric.engestrom@imgtec.com> (raw)
In-Reply-To: <x49r38pj9o7.fsf@segfault.boston.devel.redhat.com>
The assert was missing a `!` to become active, but since that would only turn
it into a complicated codepath for a pr_err(), let's simply replace it.
CC: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
drivers/block/skd_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 3822eae..c04e92a 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -1905,7 +1905,7 @@ static void skd_send_internal_skspcl(struct skd_device *skdev,
break;
default:
- SKD_ASSERT("Don't know what to send");
+ pr_err("Don't know what to send");
return;
}
@@ -2105,7 +2105,7 @@ static void skd_complete_internal(struct skd_device *skdev,
break;
default:
- SKD_ASSERT("we didn't send this");
+ pr_err("we didn't send this");
}
}
--
Cheers,
Eric
next prev parent reply other threads:[~2016-09-16 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 10:26 [PATCH] " Eric Engestrom
2016-09-12 17:43 ` Jeff Moyer
2016-09-16 9:31 ` Eric Engestrom [this message]
2016-09-16 11:59 ` [PATCH v2] " Johannes Thumshirn
2016-09-16 12:40 ` Jeff Moyer
2016-09-16 13:06 ` Eric Engestrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916093125.14322-1-eric.engestrom@imgtec.com \
--to=eric.engestrom@imgtec.com \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=jmoyer@redhat.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=ming.l@ssi.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®