From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Pratyush Anand <panand@redhat.com>
Cc: mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com,
x86@kernel.org, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, prarit@redhat.com,
dzickus@redhat.com, dyoung@redhat.com, a.zummo@towertech.it
Subject: Re: [PATCH] rtc/rtc-cmos: Initialize hpet timer before irq is registered
Date: Tue, 20 Sep 2016 00:23:19 +0200 [thread overview]
Message-ID: <20160919222319.qvakrltsv52gu2hc@piout.net> (raw)
In-Reply-To: <19b150a2f1087b80757d62770d99833781e57b31.1473862685.git.panand@redhat.com>
On 15/09/2016 at 09:38:16 +0530, Pratyush Anand wrote :
> We have observed on few x86 machines with rtc-cmos device that
> hpet_rtc_interrupt() is called just after irq registration and before
> cmos_do_probe() could call hpet_rtc_timer_init().
>
> So, neither hpet_default_delta nor hpet_t1_cmp is initialized by the time
> interrupt is raised in the given situation, and this results in NMI
> watchdog LOCKUP.
>
> It has only been observed sporadically on kdump secondary kernels.
>
[...]
>
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> ---
> drivers/rtc/rtc-cmos.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2016-09-19 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 4:08 Pratyush Anand
2016-09-19 21:42 ` Thomas Gleixner
2016-09-19 22:23 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919222319.qvakrltsv52gu2hc@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=dyoung@redhat.com \
--cc=dzickus@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=panand@redhat.com \
--cc=prarit@redhat.com \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®