From: Josh Poimboeuf <jpoimboe@redhat.com>
To: tip-bot for Josh Poimboeuf <tipbot@zytor.com>
Cc: linux-tip-commits@vger.kernel.org, brgerst@gmail.com,
tglx@linutronix.de, keescook@chromium.org, dvlasenk@redhat.com,
byungchul.park@lge.com, fweisbec@gmail.com, luto@amacapital.net,
mingo@kernel.org, hpa@zytor.com, torvalds@linux-foundation.org,
luto@kernel.org, peterz@infradead.org,
linux-kernel@vger.kernel.org, nilayvaish@gmail.com,
rostedt@goodmis.org, bp@alien8.de
Subject: [PATCH] x86/dumpstack: fix show_stack() task pointer regression
Date: Tue, 20 Sep 2016 10:53:40 -0500 [thread overview]
Message-ID: <20160920155340.yhewlx7vmgmov5fb@treble> (raw)
In-Reply-To: <tip-e18bcccd1a4ecb41e99678e002ef833586185bf1@git.kernel.org>
On Tue, Sep 20, 2016 at 08:01:02AM -0700, tip-bot for Josh Poimboeuf wrote:
> Commit-ID: e18bcccd1a4ecb41e99678e002ef833586185bf1
> Gitweb: http://git.kernel.org/tip/e18bcccd1a4ecb41e99678e002ef833586185bf1
> Author: Josh Poimboeuf <jpoimboe@redhat.com>
> AuthorDate: Fri, 16 Sep 2016 14:18:16 -0500
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue, 20 Sep 2016 08:29:34 +0200
>
> x86/dumpstack: Convert show_trace_log_lvl() to use the new unwinder
Ingo,
My apologies, I introduced a small regression with this patch -- another
rebase gone bad. Here's the fix:
---
From: Josh Poimboeuf <jpoimboe@redhat.com>
Subject: [PATCH] x86/dumpstack: fix show_stack() task pointer regression
With the following commit:
e18bcccd1a4e ("x86/dumpstack: Convert show_trace_log_lvl() to use the new unwinder")
The task pointer argument to show_stack_log_lvl() in show_stack() was
inadvertently changed to 'current'.
Fixes: e18bcccd1a4e ("x86/dumpstack: Convert show_trace_log_lvl() to use the new unwinder")
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
arch/x86/kernel/dumpstack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 999de3b..9b7cf5c 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -164,7 +164,7 @@ void show_stack(struct task_struct *task, unsigned long *sp)
if (!sp && task == current)
sp = get_stack_pointer(current, NULL);
- show_stack_log_lvl(current, NULL, sp, "");
+ show_stack_log_lvl(task, NULL, sp, "");
}
void show_stack_regs(struct pt_regs *regs)
--
2.7.4
next prev parent reply other threads:[~2016-09-20 15:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 19:18 [PATCH v2 0/6] x86/dumpstack: replace dump_trace() with a new unwinder Josh Poimboeuf
2016-09-16 19:18 ` [PATCH v2 1/6] x86/unwind: add new unwind interface and implementations Josh Poimboeuf
2016-09-20 14:59 ` [tip:x86/asm] x86/unwind: Add " tip-bot for Josh Poimboeuf
2016-09-16 19:18 ` [PATCH v2 2/6] perf/x86: convert perf_callchain_kernel() to use the new unwinder Josh Poimboeuf
2016-09-20 14:59 ` [tip:x86/asm] perf/x86: Convert " tip-bot for Josh Poimboeuf
2016-09-16 19:18 ` [PATCH v2 3/6] x86/stacktrace: convert save_stack_trace_*() " Josh Poimboeuf
2016-09-20 15:00 ` [tip:x86/asm] x86/stacktrace: Convert " tip-bot for Josh Poimboeuf
2016-09-16 19:18 ` [PATCH v2 4/6] oprofile/x86: convert x86_backtrace() " Josh Poimboeuf
2016-09-20 15:00 ` [tip:x86/asm] oprofile/x86: Convert " tip-bot for Josh Poimboeuf
2016-09-16 19:18 ` [PATCH v2 5/6] x86/dumpstack: convert show_trace_log_lvl() " Josh Poimboeuf
2016-09-20 15:01 ` [tip:x86/asm] x86/dumpstack: Convert " tip-bot for Josh Poimboeuf
2016-09-20 15:53 ` Josh Poimboeuf [this message]
2016-09-20 21:48 ` [tip:x86/asm] x86/dumpstack: Fix show_stack() task pointer regression tip-bot for Josh Poimboeuf
2016-09-16 19:18 ` [PATCH v2 6/6] x86/dumpstack: remove dump_trace() and related callbacks Josh Poimboeuf
2016-09-20 15:01 ` [tip:x86/asm] x86/dumpstack: Remove " tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920155340.yhewlx7vmgmov5fb@treble \
--to=jpoimboe@redhat.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=byungchul.park@lge.com \
--cc=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=nilayvaish@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tipbot@zytor.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®