From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Nilay Vaish <nilayvaish@gmail.com>,
the arch/x86 maintainers <x86@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Brian Gerst <brgerst@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 3/9] x86/entry/32: fix the end of the stack for newly forked tasks
Date: Wed, 21 Sep 2016 06:35:16 -0500 [thread overview]
Message-ID: <20160921113516.rutcda4fadszs6eb@treble> (raw)
In-Reply-To: <CALCETrUeHQhRQm93pjwZfM9Oc=A8cA2_Cw4WyAirc+bxJf==yg@mail.gmail.com>
On Tue, Sep 20, 2016 at 11:39:35PM -0700, Andy Lutomirski wrote:
> > And the ia64 entry code has some similar language:
> >
> > /*
> > * Invoke schedule_tail(task) while preserving in0-in7, which may be needed
> > * in case a system call gets restarted.
> > */
> > GLOBAL_ENTRY(ia64_invoke_schedule_tail)
> > ...
>
> That comment has to be wrong. What syscall could possibly be
> restarted across schedule_tail()? It's a brand new thread and has
> literally never done a syscall.
Hm, yeah, that comment doesn't make any sense.
> There may be another reason that the registers are live there, but I
> generally do my best to never look at ia64 asm code.
Yeah, I'm just going to turn around, pretend I never saw it, and slowly
walk away...
--
Josh
next prev parent reply other threads:[~2016-09-21 11:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 20:02 [PATCH 0/9] x86/entry/head: standardize the end of the stack Josh Poimboeuf
2016-09-20 20:02 ` [PATCH 1/9] x86/entry/head/32: use local labels Josh Poimboeuf
2016-09-21 0:57 ` Andy Lutomirski
2016-09-21 2:52 ` Josh Poimboeuf
2016-09-20 20:02 ` [PATCH 2/9] x86/entry/32: rename 'error_code' to 'common_exception' Josh Poimboeuf
2016-09-20 20:02 ` [PATCH 3/9] x86/entry/32: fix the end of the stack for newly forked tasks Josh Poimboeuf
2016-09-21 1:10 ` Brian Gerst
2016-09-21 3:25 ` Josh Poimboeuf
2016-09-21 3:33 ` Josh Poimboeuf
2016-09-21 6:39 ` Andy Lutomirski
2016-09-21 11:35 ` Josh Poimboeuf [this message]
2016-09-20 20:02 ` [PATCH 4/9] x86/head/32: fix the end of the stack for idle tasks Josh Poimboeuf
2016-09-20 20:02 ` [PATCH 5/9] x86/smp: fix initial idle stack location on 32-bit Josh Poimboeuf
2016-09-20 20:02 ` [PATCH 6/9] x86/asm/head: use a common function for starting CPUs Josh Poimboeuf
2016-09-20 20:02 ` [PATCH 7/9] x86/head: put real return address on idle task stack Josh Poimboeuf
2016-09-20 20:02 ` [PATCH 8/9] x86/head: fix the end of the stack for idle tasks Josh Poimboeuf
2016-09-20 20:02 ` [PATCH 9/9] x86: move _stext marker to before head code Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921113516.rutcda4fadszs6eb@treble \
--to=jpoimboe@redhat.com \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=nilayvaish@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®