mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrey Utkin <andrey_utkin@fastmail.com>
To: Jannik Becher <becher.jannik@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: wlan-ng: fixed a coding style issue
Date: Thu, 22 Sep 2016 23:32:02 +0300	[thread overview]
Message-ID: <20160922203201.33pwuzd3lncyjncf@zver> (raw)
In-Reply-To: <20160922191146.6420-1-Becher.Jannik@gmail.com>

On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote:
> removed a space after a cast to obtain the coding style.
> 
> Signed-off-by: Jannik Becher <Becher.Jannik@gmail.com>
> ---
>  drivers/staging/wlan-ng/p80211req.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c
> index 40627d5..ecd2fff 100644
> --- a/drivers/staging/wlan-ng/p80211req.c
> +++ b/drivers/staging/wlan-ng/p80211req.c
> @@ -110,7 +110,7 @@ static void p80211req_handle_action(struct wlandevice *wlandev, u32 *data,
>  ----------------------------------------------------------------*/
>  int p80211req_dorequest(struct wlandevice *wlandev, u8 *msgbuf)
>  {
> -	struct p80211msg *msg = (struct p80211msg *) msgbuf;
> +	struct p80211msg *msg = (struct p80211msg *)msgbuf;
>  
>  	/* Check to make sure the MSD is running */
>  	if (!((wlandev->msdstate == WLAN_MSD_HWPRESENT &&

checkpatch.pl shows that in this file there are other occurances of
style deviations - of same or other kinds. Could you please present work
on wider scope, e.g. on whole wlan-ng/, or at last making this one file
to pass checkpatch.pl --strict cleanly?

Not that I don't appreciate this small achievement, but I believe
maintainers won't merge this one, exactly because there is more work of
same kind in the same file.

  reply	other threads:[~2016-09-22 20:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 19:11 Jannik Becher
2016-09-22 20:32 ` Andrey Utkin [this message]
2016-09-22 20:52   ` becher.jannik
2016-09-22 21:03     ` Joe Perches
2016-09-22 21:14     ` Andrey Utkin
  -- strict thread matches above, loose matches on Subject: below --
2016-09-22 21:56 Jannik Becher
2016-09-22 22:05 ` Joe Perches
2016-09-22 22:39   ` becher.jannik
2016-09-22 22:52     ` Joe Perches
2016-09-22 18:01 Jannik Becher
2016-09-22 18:27 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160922203201.33pwuzd3lncyjncf@zver \
    --to=andrey_utkin@fastmail.com \
    --cc=becher.jannik@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®