From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dave Chinner <david@fromorbit.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] [4.8-rc7, regression] fault_in_multipages_readable() throws set-but-unused error
Date: Mon, 26 Sep 2016 21:24:22 +1000 [thread overview]
Message-ID: <20160926212422.0bf5a25a@canb.auug.org.au> (raw)
In-Reply-To: <CA+55aFzcVv8ZPbAeB7Gx+jg2OjPrT+d3-yA0GxKRTmjSx8uzjg@mail.gmail.com>
Hi all,
On Sun, 25 Sep 2016 20:06:19 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> exactly like you did. It's just that with 12 characters in the hex
> format, people will still be able to cut-and-paste the hash into git
> to get the full commit details even a year from now. With just 7 hex
> digits, you may well end up in the situation where you do
>
> git show e23d415
>
> and git says
>
> error: short SHA1 e23d415 is ambiguous.
> fatal: ambiguous argument 'e23d415': unknown revision or path not
> in the working tree.
>
> (it's not ambiguous today, but in a year or two it quite possibly will be).
I have already had over the years a few instances of 7 digit commit
hashes that are unique in Linus' tree but not in mine (which is a bit
of a pain if you are trying to look for context).
--
Cheers,
Stephen Rothwell
prev parent reply other threads:[~2016-09-26 11:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 23:57 Dave Chinner
2016-09-26 1:21 ` Linus Torvalds
2016-09-26 2:25 ` Dave Chinner
2016-09-26 3:06 ` Linus Torvalds
2016-09-26 11:24 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926212422.0bf5a25a@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®