mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hejianet@gmail.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
	linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru,
	jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
	vyasevich@gmail.com, nhorman@tuxdriver.com,
	steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
	marcelo.leitner@gmail.com
Subject: Re: [PATCH v4 2/7] proc: Reduce cache miss in snmp_seq_show
Date: Tue, 27 Sep 2016 09:45:51 -0400 (EDT)	[thread overview]
Message-ID: <20160927.094551.1178979867316917587.davem@davemloft.net> (raw)
In-Reply-To: <1474877355-12920-3-git-send-email-hejianet@gmail.com>

From: Jia He <hejianet@gmail.com>
Date: Mon, 26 Sep 2016 16:09:10 +0800

> +static int snmp_seq_show_tcp_udp(struct seq_file *seq, void *v)
> +{
> +	int i;
> +	unsigned long buff[TCPUDP_MIB_MAX];
> +	struct net *net = seq->private;

Please always order local variables from longest to shortest
line.

Please audit your entire patch series for this problem.

Thanks.

  reply	other threads:[~2016-09-27 13:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26  8:09 [PATCH v4 0/7] Reduce cache miss for snmp_fold_field Jia He
2016-09-26  8:09 ` [PATCH v4 1/7] net:snmp: Introduce generic interfaces for snmp_get_cpu_field{,64} Jia He
2016-09-26  8:09 ` [PATCH v4 2/7] proc: Reduce cache miss in snmp_seq_show Jia He
2016-09-27 13:45   ` David Miller [this message]
2016-09-26  8:09 ` [PATCH v4 3/7] proc: Reduce cache miss in snmp6_seq_show Jia He
2016-09-26  8:09 ` [PATCH v4 4/7] proc: Reduce cache miss in sctp_snmp_seq_show Jia He
2016-09-26  8:09 ` [PATCH v4 5/7] proc: Reduce cache miss in xfrm_statistics_seq_show Jia He
2016-09-26  8:09 ` [PATCH v4 6/7] ipv6: Remove useless parameter in __snmp6_fill_statsdev Jia He
2016-09-26  8:09 ` [PATCH v4 7/7] net: Suppress the "Comparison to NULL could be written" warnings Jia He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160927.094551.1178979867316917587.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hejianet@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=steffen.klassert@secunet.com \
    --cc=vyasevich@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®