From: David Miller <davem@davemloft.net>
To: jhs@mojatatu.com
Cc: gorcunov@gmail.com, eric.dumazet@gmail.com,
dsa@cumulusnetworks.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
avagin@openvz.org, stephen@networkplumber.org
Subject: Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets
Date: Wed, 28 Sep 2016 08:16:46 -0400 (EDT) [thread overview]
Message-ID: <20160928.081646.1634500099795129398.davem@davemloft.net> (raw)
In-Reply-To: <60b2e075-e852-f0c2-c188-631f547791d5@mojatatu.com>
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Wed, 28 Sep 2016 08:09:28 -0400
> On 16-09-28 08:07 AM, David Miller wrote:
>
>> Right, it would be legal for an existing user to have code that
>> explicitly initializes every member of the structure, including 'pad'.
>> So we have to keep that member around, at a minimum, for their sake.
>>
>
> I think we need to start labelling any new pad fields added as
> "Not UAPI. Do not fsck fondle this".
They must initialize it to zero.
next prev parent reply other threads:[~2016-09-28 12:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 9:03 Cyrill Gorcunov
2016-09-28 10:08 ` Jamal Hadi Salim
2016-09-28 10:17 ` Cyrill Gorcunov
2016-09-28 10:43 ` Jamal Hadi Salim
2016-09-28 10:51 ` Cyrill Gorcunov
2016-09-28 11:06 ` Jamal Hadi Salim
2016-09-28 11:27 ` Cyrill Gorcunov
2016-09-28 12:06 ` Jamal Hadi Salim
2016-09-28 12:09 ` David Miller
2016-09-28 12:21 ` Cyrill Gorcunov
2016-09-28 12:07 ` David Miller
2016-09-28 12:09 ` Jamal Hadi Salim
2016-09-28 12:16 ` David Miller [this message]
2016-09-28 12:27 ` Jamal Hadi Salim
2016-09-28 12:38 ` Jamal Hadi Salim
2016-09-28 12:45 ` Cyrill Gorcunov
2016-09-28 12:50 ` Jamal Hadi Salim
2016-09-28 12:57 ` Cyrill Gorcunov
2016-09-28 12:18 ` Cyrill Gorcunov
2016-09-28 12:57 ` Eric Dumazet
2016-09-28 13:02 ` Eric Dumazet
2016-09-28 13:09 ` Cyrill Gorcunov
2016-09-28 13:03 ` Cyrill Gorcunov
2016-09-28 13:29 ` Eric Dumazet
2016-09-28 13:43 ` Cyrill Gorcunov
2016-09-28 13:49 ` Eric Dumazet
2016-09-28 14:55 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928.081646.1634500099795129398.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avagin@openvz.org \
--cc=dsa@cumulusnetworks.com \
--cc=eric.dumazet@gmail.com \
--cc=gorcunov@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®