From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: kashyap.desai@avagotech.com, sumit.saxena@avagotech.com,
uday.lingala@avagotech.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, megaraidlinux.pdl@avagotech.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
xie.baoyou@zte.com.cn, han.fei@zte.com.cn,
tang.qiang007@zte.com.cn
Subject: Re: [PATCH 2/2] megaraid_sas: clean function declarations in megaraid_sas_fusion.c up
Date: Fri, 30 Sep 2016 16:34:34 +0200 [thread overview]
Message-ID: <201609301634.34846.arnd@arndb.de> (raw)
In-Reply-To: <1475228702-21408-1-git-send-email-baoyou.xie@linaro.org>
On Friday 30 September 2016, Baoyou Xie wrote:
> int megasas_transition_to_ready(struct megasas_instance *instance, int ocr);
> -void megaraid_sas_kill_hba(struct megasas_instance *instance);
>
> extern u32 megasas_dbg_lvl;
> -void megasas_sriov_heartbeat_handler(unsigned long instance_addr);
> -int megasas_sriov_start_heartbeat(struct megasas_instance *instance,
> - int initial);
> -void megasas_start_timer(struct megasas_instance *instance,
> - struct timer_list *timer,
> - void *fn, unsigned long interval);
> extern struct megasas_mgmt_info megasas_mgmt_info;
> extern unsigned int resetwaittime;
> extern unsigned int dual_qdepth_disable;
I think you should remove all "extern" declarations from the .c file at the same
time here, and move them to an appropriate header, or remove them in case the symbol
is already gone and we only have the declaration left.
Arnd
prev parent reply other threads:[~2016-09-30 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 9:45 Baoyou Xie
2016-09-30 14:34 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201609301634.34846.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=han.fei@zte.com.cn \
--cc=jejb@linux.vnet.ibm.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@avagotech.com \
--cc=sumit.saxena@avagotech.com \
--cc=tang.qiang007@zte.com.cn \
--cc=uday.lingala@avagotech.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome