From: David Miller <davem@davemloft.net>
To: dmitry.torokhov@gmail.com
Cc: tyhicks@canonical.com, serge.hallyn@ubuntu.com,
james.l.morris@oracle.com, ebiederm@xmission.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Use ns_capable_noaudit() when determining net sysctl permissions
Date: Sat, 01 Oct 2016 03:25:04 -0400 (EDT) [thread overview]
Message-ID: <20161001.032504.1254372735513201320.davem@davemloft.net> (raw)
In-Reply-To: <20160930222431.GA30208@dtor-ws>
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: Fri, 30 Sep 2016 15:24:31 -0700
> From: Tyler Hicks <tyhicks@canonical.com>
>
> The capability check should not be audited since it is only being used
> to determine the inode permissions. A failed check does not indicate a
> violation of security policy but, when an LSM is enabled, a denial audit
> message was being generated.
>
> The denial audit message caused confusion for some application authors
> because root-running Go applications always triggered the denial. To
> prevent this confusion, the capability check in net_ctl_permissions() is
> switched to the noaudit variant.
>
> BugLink: https://launchpad.net/bugs/1465724
>
> Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
> Signed-off-by: James Morris <james.l.morris@oracle.com>
> [dtor: reapplied after e79c6a4fc923 ("net: make net namespace sysctls
> belong to container's owner") accidentally reverted the change.]
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied, but please be clear in the future what tree a patch
is targetting, in this case 'net-next'.
You can indicate this in the Subject line "[PATCH net-next]".
next prev parent reply other threads:[~2016-10-01 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 22:24 Dmitry Torokhov
2016-10-01 7:25 ` David Miller [this message]
2016-10-01 18:59 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161001.032504.1254372735513201320.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=ebiederm@xmission.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=serge.hallyn@ubuntu.com \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®