mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: "Winkler, Tomas" <tomas.winkler@intel.com>,
	"tpmdd-devel@lists.sourceforge.net" 
	<tpmdd-devel@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: don't destroy chip device prematurely
Date: Mon, 3 Oct 2016 10:03:08 -0600	[thread overview]
Message-ID: <20161003160308.GA6801@obsidianresearch.com> (raw)
In-Reply-To: <20161003124225.GD9990@intel.com>

On Mon, Oct 03, 2016 at 03:42:25PM +0300, Jarkko Sakkinen wrote:

> > I've looked to the registration code and it indeed has few more issues

?

> > Maybe TPM_CHIP_FLAG_REGISTERED can be used for sealing the access
> > to the device during deregistration, current usage is void.

This is done via chip->ops = NULL and the rwlock scheme.
 
> Good catch BTW. This flag has gone quite obsolote.

I think all the drivers have been updated at this point so we can
probably get rid of it entirely.

Jason

  reply	other threads:[~2016-10-03 16:03 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-02  7:39 Tomas Winkler
2016-10-02 10:17 ` Jarkko Sakkinen
2016-10-02 10:24   ` Jarkko Sakkinen
2016-10-02 21:21     ` Jason Gunthorpe
2016-10-03  7:05       ` Winkler, Tomas
2016-10-03  7:38         ` Winkler, Tomas
2016-10-03 12:42           ` Jarkko Sakkinen
2016-10-03 16:03             ` Jason Gunthorpe [this message]
2016-10-03 17:30               ` Winkler, Tomas
2016-10-03 12:48         ` Jarkko Sakkinen
2016-10-04  5:19           ` Jarkko Sakkinen
2016-10-04 16:47             ` Jason Gunthorpe
2016-10-04 21:55               ` Winkler, Tomas
2016-10-04 23:10                 ` Jason Gunthorpe
2016-10-05  7:48                   ` Winkler, Tomas
2016-10-05 15:15                     ` Jarkko Sakkinen
2016-10-05 16:37                       ` Jason Gunthorpe
2016-10-05 17:11                     ` Jason Gunthorpe
2016-10-05 20:09                       ` Winkler, Tomas
2016-10-05 21:16                         ` Jason Gunthorpe
2016-10-06  0:43                           ` Winkler, Tomas
2016-10-06  2:07                             ` Jason Gunthorpe
2016-10-07 14:24                               ` Winkler, Tomas
2016-10-07 19:17                                 ` Jason Gunthorpe
2016-10-07 20:10                                   ` Winkler, Tomas
2016-10-08 10:47                                 ` Jarkko Sakkinen
2016-10-05 10:02               ` Jarkko Sakkinen
2016-10-05 16:27                 ` Jason Gunthorpe
2016-10-06 11:23                   ` Jarkko Sakkinen
2016-10-06 16:22                     ` Jason Gunthorpe
2016-10-06 16:46                       ` Jarkko Sakkinen
2016-10-05 10:09               ` Jarkko Sakkinen
2016-10-03 16:00         ` Jason Gunthorpe
2016-10-03 17:16           ` Winkler, Tomas
2016-10-03 17:30             ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161003160308.GA6801@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome