From: David Miller <davem@davemloft.net>
To: mike.looijmans@topic.nl
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, andrew@lunn.ch, f.fainelli@gmail.com
Subject: Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings
Date: Thu, 06 Oct 2016 20:49:23 -0400 (EDT) [thread overview]
Message-ID: <20161006.204923.1914066918563386131.davem@davemloft.net> (raw)
In-Reply-To: <1475676188-10639-1-git-send-email-mike.looijmans@topic.nl>
From: Mike Looijmans <mike.looijmans@topic.nl>
Date: Wed, 5 Oct 2016 16:03:08 +0200
> The KSZ9031 skew registers contain an offset, the chip's default value
> is "neutral" which does not add any skew. Programming a 0 into a skew
> property will actually set it the maximal negative adjustment and not
> to a neutral position as one would expect.
>
> Explain this situation in the devicetree binding documentation and list
> the settings that the chip considers neutral.
>
> Changing the implementation to accept negative values would have been
> a better solution, but would break existing configurations.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Applied.
prev parent reply other threads:[~2016-10-07 0:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 14:03 Mike Looijmans
2016-10-06 11:04 ` Florian Fainelli
2016-10-07 0:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006.204923.1914066918563386131.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.looijmans@topic.nl \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®