From: Kyle Roeschley <kyle.roeschley@ni.com>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyle Roeschley <kyle.roeschley@ni.com>
Subject: [RFC] net: phy: smsc: Disable auto-negotiation on startup
Date: Mon, 10 Oct 2016 12:41:23 -0500 [thread overview]
Message-ID: <20161010174123.21436-1-kyle.roeschley@ni.com> (raw)
Because the SMSC PHY completes auto-negotiation before the driver is
ready to handle interrupts, the PHY state machine never realizes that we
have a link. Clear the ANENABLE bit on initialization, which lets
genphy_config_aneg do its thing when that code is hit later.
While this patch does fix the problem we see (no link on boot without
re-plugging the cable), it seems like the generic PHY code should be
able to handle auto-negotiation completing before interrupts are
enabled. Submitted as an RFC in the hopes that someone has an idea as to
how that could be done.
This fix is copied from commit 99f81afc139c ("phy: micrel: Disable auto
negotiation on startup").
Signed-off-by: Kyle Roeschley <kyle.roeschley@ni.com>
---
drivers/net/phy/smsc.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index b62c4aa..8de8011 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c
@@ -62,6 +62,16 @@ static int smsc_phy_config_init(struct phy_device *phydev)
return rc;
}
+ if (phy_interrupt_is_valid(phydev)) {
+ rc = phy_read(phydev, MII_BMCR);
+ if (rc < 0)
+ return rc;
+
+ rc = phy_write(phydev, MII_BMCR, rc & ~BMCR_ANENABLE);
+ if (rc < 0)
+ return rc;
+ }
+
return smsc_phy_ack_interrupt(phydev);
}
--
2.9.3
next reply other threads:[~2016-10-10 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 17:41 Kyle Roeschley [this message]
2016-10-11 14:32 ` Jeremy Linton
2016-10-12 15:09 ` Kyle Roeschley
2016-10-12 9:13 ` Florian Fainelli
2016-10-12 15:05 ` Kyle Roeschley
2016-10-12 19:55 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010174123.21436-1-kyle.roeschley@ni.com \
--to=kyle.roeschley@ni.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®