From: Andrew Lunn <andrew@lunn.ch>
To: Kyle Roeschley <kyle.roeschley@ni.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup
Date: Wed, 12 Oct 2016 21:55:00 +0200 [thread overview]
Message-ID: <20161012195500.GA13125@lunn.ch> (raw)
In-Reply-To: <20161012150533.dctakcjczclk2mml@senary>
On Wed, Oct 12, 2016 at 10:05:33AM -0500, Kyle Roeschley wrote:
> On Wed, Oct 12, 2016 at 02:13:06AM -0700, Florian Fainelli wrote:
> > On 10/10/2016 10:41 AM, Kyle Roeschley wrote:
> > > Because the SMSC PHY completes auto-negotiation before the driver is
> > > ready to handle interrupts, the PHY state machine never realizes that we
> > > have a link. Clear the ANENABLE bit on initialization, which lets
> > > genphy_config_aneg do its thing when that code is hit later.
> > >
> > > While this patch does fix the problem we see (no link on boot without
> > > re-plugging the cable), it seems like the generic PHY code should be
> > > able to handle auto-negotiation completing before interrupts are
> > > enabled. Submitted as an RFC in the hopes that someone has an idea as to
> > > how that could be done.
> > >
> > > This fix is copied from commit 99f81afc139c ("phy: micrel: Disable auto
> > > negotiation on startup").
> >
> > Do you mind trying:
> >
> > https://www.spinics.net/lists/netdev/msg397857.html
> >
> > and see if you do get link interrupts without your patch applied? Thanks!
>
> Yep, that fixes it. I figured there was some state machine issue I was missing.
> Thanks very much!
Humm, O.K, time to pull that patch out of the series and make it
standalone.
Andrew
prev parent reply other threads:[~2016-10-12 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 17:41 Kyle Roeschley
2016-10-11 14:32 ` Jeremy Linton
2016-10-12 15:09 ` Kyle Roeschley
2016-10-12 9:13 ` Florian Fainelli
2016-10-12 15:05 ` Kyle Roeschley
2016-10-12 19:55 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012195500.GA13125@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kyle.roeschley@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®