From: David Miller <davem@davemloft.net>
To: gorcunov@gmail.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, jhs@mojatatu.com,
dsa@cumulusnetworks.com, linux-kernel@vger.kernel.org,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, avagin@openvz.org, stephen@networkplumber.org
Subject: Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets
Date: Wed, 12 Oct 2016 01:50:22 -0400 (EDT) [thread overview]
Message-ID: <20161012.015022.2273537782016406180.davem@davemloft.net> (raw)
In-Reply-To: <20161006100055.GA1941@uranus.lan>
From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Thu, 6 Oct 2016 13:00:55 +0300
> v6:
> - use sdiag_raw_protocol() helper which will access @pad
> structure used for raw sockets protocol specification:
> we can't simply rename this member without breaking uapi.
Macros that look like function calls and are also lvalues tend to be
troublesome.
I know what you're trying to achieve, you want a named way to access
this so that the intent and semantics are clear.
But I'd rather you do something that provides a way by which normal
struct member accesses do the job, and your earlier patches achieved
this.
next prev parent reply other threads:[~2016-10-12 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 10:00 Cyrill Gorcunov
2016-10-12 5:50 ` David Miller [this message]
2016-10-12 6:53 ` Cyrill Gorcunov
2016-10-12 23:55 ` David Miller
2016-10-13 7:16 ` Cyrill Gorcunov
2016-10-13 15:43 ` David Ahern
2016-10-13 15:58 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012.015022.2273537782016406180.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avagin@openvz.org \
--cc=dsa@cumulusnetworks.com \
--cc=eric.dumazet@gmail.com \
--cc=gorcunov@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®