mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] EDAC, sb_edac: Use Intel family processor macros
@ 2016-10-12 18:23 Piotr Luc
  2016-10-12 18:23 ` [PATCH 1/2] " Piotr Luc
  2016-10-12 18:23 ` [PATCH 2/2] EDAC, sb_edac: Add Knights Mill CPUID Piotr Luc
  0 siblings, 2 replies; 3+ messages in thread
From: Piotr Luc @ 2016-10-12 18:23 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, linux-edac, linux-kernel
  Cc: Doug Thompson, Borislav Petkov

The intention of this series is to add KNM CPU ID to EDAC.
The first patch improves code style by replacing raw numbers of CPUIDs 
with descriptive macros of processor names and removes trailing
comments that are not needed anymore.
The second patch enables EDAC to support KNM processor.

The second patch depends on patch: 
x86/cpu/intel: Add Knights Mill to Intel family
https://lkml.kernel.org/r/20161012180520.30976-1-piotr.luc () intel ! com

Piotr Luc (2):
  EDAC, sb_edac: Use Intel family processor macros
  EDAC, sb_edac: Add Knights Mill CPUID

 drivers/edac/sb_edac.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

-- 
2.10.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] EDAC, sb_edac: Use Intel family processor macros
  2016-10-12 18:23 [PATCH 0/2] EDAC, sb_edac: Use Intel family processor macros Piotr Luc
@ 2016-10-12 18:23 ` Piotr Luc
  2016-10-12 18:23 ` [PATCH 2/2] EDAC, sb_edac: Add Knights Mill CPUID Piotr Luc
  1 sibling, 0 replies; 3+ messages in thread
From: Piotr Luc @ 2016-10-12 18:23 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, linux-edac, linux-kernel
  Cc: Doug Thompson, Borislav Petkov, Luck, Tony, Shevchenko, Andriy

Use macros of Intel processor families instead of raw numbers.

Signed-off-by: Piotr Luc <piotr.luc@intel.com>
Reviewed-by: Dave Hansen <dave.hansen@intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Doug Thompson <dougthompson@xmission.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
---
 drivers/edac/sb_edac.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index ce0067b..90564bc 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -23,6 +23,7 @@
 #include <linux/math64.h>
 #include <linux/mod_devicetable.h>
 #include <asm/cpu_device_id.h>
+#include <asm/intel-family.h>
 #include <asm/processor.h>
 #include <asm/mce.h>
 
@@ -3366,12 +3367,12 @@ fail0:
 	{ X86_VENDOR_INTEL, 6, model, 0, (unsigned long)&table }
 
 static const struct x86_cpu_id sbridge_cpuids[] = {
-	ICPU(0x2d, pci_dev_descr_sbridge_table),	/* SANDY_BRIDGE */
-	ICPU(0x3e, pci_dev_descr_ibridge_table),	/* IVY_BRIDGE */
-	ICPU(0x3f, pci_dev_descr_haswell_table),	/* HASWELL */
-	ICPU(0x4f, pci_dev_descr_broadwell_table),	/* BROADWELL */
-	ICPU(0x56, pci_dev_descr_broadwell_table),	/* BROADWELL-DE */
-	ICPU(0x57, pci_dev_descr_knl_table),		/* KNIGHTS_LANDING */
+	ICPU(INTEL_FAM6_SANDYBRIDGE_X, pci_dev_descr_sbridge_table),
+	ICPU(INTEL_FAM6_IVYBRIDGE_X, pci_dev_descr_ibridge_table),
+	ICPU(INTEL_FAM6_HASWELL_X, pci_dev_descr_haswell_table),
+	ICPU(INTEL_FAM6_BROADWELL_X, pci_dev_descr_broadwell_table),
+	ICPU(INTEL_FAM6_BROADWELL_XEON_D, pci_dev_descr_broadwell_table),
+	ICPU(INTEL_FAM6_XEON_PHI_KNL, pci_dev_descr_knl_table),
 	{ }
 };
 MODULE_DEVICE_TABLE(x86cpu, sbridge_cpuids);
-- 
2.10.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] EDAC, sb_edac: Add Knights Mill CPUID
  2016-10-12 18:23 [PATCH 0/2] EDAC, sb_edac: Use Intel family processor macros Piotr Luc
  2016-10-12 18:23 ` [PATCH 1/2] " Piotr Luc
@ 2016-10-12 18:23 ` Piotr Luc
  1 sibling, 0 replies; 3+ messages in thread
From: Piotr Luc @ 2016-10-12 18:23 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, linux-edac, linux-kernel
  Cc: Doug Thompson, Borislav Petkov, Luck, Tony, Shevchenko, Andriy

Add Knights Mill (KNM) to the list of CPUIDs supported by sb_edac.

Signed-off-by: Piotr Luc <piotr.luc@intel.com>
Reviewed-by: Dave Hansen <dave.hansen@intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Doug Thompson <dougthompson@xmission.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
---
Depends-on: x86/cpu/intel: Add Knights Mill to Intel family
https://lkml.kernel.org/r/20161012180520.30976-1-piotr.luc () intel ! com

 drivers/edac/sb_edac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index 90564bc..3ffc737 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -3373,6 +3373,7 @@ static const struct x86_cpu_id sbridge_cpuids[] = {
 	ICPU(INTEL_FAM6_BROADWELL_X, pci_dev_descr_broadwell_table),
 	ICPU(INTEL_FAM6_BROADWELL_XEON_D, pci_dev_descr_broadwell_table),
 	ICPU(INTEL_FAM6_XEON_PHI_KNL, pci_dev_descr_knl_table),
+	ICPU(INTEL_FAM6_XEON_PHI_KNM, pci_dev_descr_knl_table),
 	{ }
 };
 MODULE_DEVICE_TABLE(x86cpu, sbridge_cpuids);
-- 
2.10.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-10-12 18:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-12 18:23 [PATCH 0/2] EDAC, sb_edac: Use Intel family processor macros Piotr Luc
2016-10-12 18:23 ` [PATCH 1/2] " Piotr Luc
2016-10-12 18:23 ` [PATCH 2/2] EDAC, sb_edac: Add Knights Mill CPUID Piotr Luc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®