mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: kbuild test robot <fengguang.wu@intel.com>, jonas@southpole.se
Cc: Dave Chinner <david@fromorbit.com>,
	kbuild-all@01.org, linux-kernel@vger.kernel.org
Subject: Re: fs/xfs/xfs_ondisk.h:96:2: error: call to '__compiletime_assert_96' declared with attribute error: XFS: sizeof(xfs_dir2_sf_entry_t) is wrong, expected 3
Date: Sun, 16 Oct 2016 09:45:56 -0700	[thread overview]
Message-ID: <20161016164556.GA30222@infradead.org> (raw)
In-Reply-To: <201610161706.PmSovtpj%fengguang.wu@intel.com>



> head:   1001354ca34179f3db924eb66672442a173147dc

That's Linux 4.9-rc1

> 30cbc591 Darrick J. Wong 2016-03-09 @86  	XFS_CHECK_STRUCT_SIZE(xfs_dir2_data_unused_t,		6);

But that's not how xfs_ondisk.h in 4.9-rc1 looks like

> 30cbc591 Darrick J. Wong 2016-03-09 @96  	XFS_CHECK_STRUCT_SIZE(xfs_dir2_sf_entry_t,		3);

And that's line 119.

Something is odd about this report. 

But both xfs_dir2_data_unused_t and xfs_dir2_sf_entry_t have one thing in
common: they are strutures that aren't padded to a natural alignment at
the end.  It seems like the openrisc gcc does implicit padding for them,
which sounds like a nightmware waiting to happen for any sort of disk
or network structure, so I'm really not sure if we should work around
it in xfs.

  reply	other threads:[~2016-10-16 16:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-16  9:29 kbuild test robot
2016-10-16 16:45 ` Christoph Hellwig [this message]
2016-10-17 14:09   ` [kbuild-all] " Fengguang Wu
  -- strict thread matches above, loose matches on Subject: below --
2017-02-12 12:00 kbuild test robot
2017-02-05 11:54 kbuild test robot
2017-01-22 11:10 kbuild test robot
2017-01-01  0:35 kbuild test robot
2016-12-25 12:41 kbuild test robot
2016-12-11  2:35 kbuild test robot
2016-12-05  1:36 kbuild test robot
2016-11-20  5:42 kbuild test robot
2016-11-12 23:05 kbuild test robot
2016-11-06  1:36 kbuild test robot
2016-10-30  5:20 kbuild test robot
2016-10-23  7:29 kbuild test robot
2016-10-02 12:41 kbuild test robot
2016-09-23  6:08 kbuild test robot
2016-09-11  5:41 kbuild test robot
2016-09-04 12:07 kbuild test robot
2016-08-22 15:29 kbuild test robot
2016-07-31 19:02 kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161016164556.GA30222@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=fengguang.wu@intel.com \
    --cc=jonas@southpole.se \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome