* possible if/else bug in dc395x.c
@ 2016-10-16 17:26 Nicholas Mc Guire
0 siblings, 0 replies; only message in thread
From: Nicholas Mc Guire @ 2016-10-16 17:26 UTC (permalink / raw)
To: dc395x; +Cc: linux-kernel, linux-scsi
Hi !
in drivers/scsi/dc395x.c:srb_done()
3387 if (srb->total_xfer_length
3388 && srb->total_xfer_length >= cmd->underflow)
3389 cmd->result =
3390 MK_RES_LNX(DRIVER_SENSE, DID_OK,
3391 srb->end_message, CHECK_CONDITION);
3392 /*SET_RES_DID(cmd->result,DID_OK) */
3393 else
3394 cmd->result =
3395 MK_RES_LNX(DRIVER_SENSE, DID_OK,
3396 srb->end_message, CHECK_CONDITION);
(line numbers from 4.9.0-rc1, localversion-next next-20161016)
The if and else are identical, these lines date back to pre-git (so git blame
assigns them to the initial 2.6.12-rc2 import).
Not sure if it makes much sense trying to fix up something like this at all
is it worth trying to figure out what this should be ? I would asume that
given that this survived atleast 12 years in this form that the condition
could be removed and the cmd-> result set unconditionally here.
thx!
hofrat
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-10-16 17:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-16 17:26 possible if/else bug in dc395x.c Nicholas Mc Guire
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome