Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote:
> From: Gustaf Lindström <gl@axentia.se>
> 
> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
> 
> The simple-panel driver is used to get support for essential
> functionality of the panel.
> 
> Signed-off-by: Gustaf Lindström <gl@axentia.se>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 85143d1b9b31..58cfe0a7a9d6 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = {
>  	},
>  };
>  
> +static const struct drm_display_mode sharp_lq150x1lg11_mode = {
> +	.clock = 71100,
> +	.hdisplay = 1024,
> +	.hsync_start = 1024 + 168,
> +	.hsync_end = 1024 + 168 + 64,
> +	.htotal = 1024 + 168 + 64 + 88,
> +	.vdisplay = 768,
> +	.vsync_start = 768 + 37,
> +	.vsync_end = 768 + 37 + 2,
> +	.vtotal = 768 + 37 + 2 + 8,
> +	.vrefresh = 60,
> +};
> +
> +static const struct panel_desc sharp_lq150x1lg11 = {
> +	.modes = &sharp_lq150x1lg11_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 304,
> +		.height = 228,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,

This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for
RGB565 panels.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]