[PATCH v4 0/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

[PATCH v4 0/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

[Peter Rosin]

Hi!

New attempt to get this upstreamed. v4 addresses review comments
from Rob (lvds -> sellvds and a couple of typos).

Cheers,
Peter

Gustaf Lindström (1):
  drm/panel: simple: add support for Sharp LQ150X1LG11 panels

Peter Rosin (1):
  dt-bindings: display: Add Sharp LQ150X1LG11 panel binding

 .../bindings/display/panel/sharp,lq150x1lg11.txt   | 36 ++++++++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c               | 27 ++++++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt

-- 
2.1.4

[PATCH v4 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding

[Peter Rosin]

The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 .../bindings/display/panel/sharp,lq150x1lg11.txt   | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt

diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
new file mode 100644
index 000000000000..0f57c3143506
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
@@ -0,0 +1,36 @@
+Sharp 15" LQ150X1LG11 XGA TFT LCD panel
+
+Required properties:
+- compatible: should be "sharp,lq150x1lg11"
+- power-supply: regulator to provide the VCC supply voltage (3.3 volts)
+
+Optional properties:
+- backlight: phandle of the backlight device
+- rlud-gpios: a single GPIO for the RL/UD (rotate 180 degrees) pin.
+- sellvds-gpios: a single GPIO for the SELLVDS pin.
+
+If rlud-gpios and/or sellvds-gpios are not specified, the RL/UD and/or SELLVDS
+pins are assumed to be handled appropriately by the hardware.
+
+Example:
+
+	backlight: backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pwm 0 100000>;                      /* VBR */
+
+		brightness-levels = <0 20 40 60 80 100>;
+		default-brightness-level = <2>;
+
+		power-supply = <&vdd_12v_reg>;               /* VDD */
+		enable-gpios = <&gpio 42 GPIO_ACTIVE_HIGH>;  /* XSTABY */
+	};
+
+	panel {
+		compatible = "sharp,lq150x1lg11";
+
+		power-supply = <&vcc_3v3_reg>;               /* VCC */
+
+		backlight = <&backlight>;
+		rlud-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;    /* RL/UD */
+		sellvds-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>; /* SELLVDS */
+	};
-- 
2.1.4

Re: [PATCH v4 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding

[Rob Herring]

On Tue, Oct 04, 2016 at 05:29:20PM +0200, Peter Rosin wrote:
> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  .../bindings/display/panel/sharp,lq150x1lg11.txt   | 36 ++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt

Acked-by: Rob Herring <robh@kernel.org>

[PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

[Peter Rosin]

From: Gustaf Lindström <gl@axentia.se>

The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.

The simple-panel driver is used to get support for essential
functionality of the panel.

Signed-off-by: Gustaf Lindström <gl@axentia.se>
Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 85143d1b9b31..58cfe0a7a9d6 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = {
 	},
 };
 
+static const struct drm_display_mode sharp_lq150x1lg11_mode = {
+	.clock = 71100,
+	.hdisplay = 1024,
+	.hsync_start = 1024 + 168,
+	.hsync_end = 1024 + 168 + 64,
+	.htotal = 1024 + 168 + 64 + 88,
+	.vdisplay = 768,
+	.vsync_start = 768 + 37,
+	.vsync_end = 768 + 37 + 2,
+	.vtotal = 768 + 37 + 2 + 8,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc sharp_lq150x1lg11 = {
+	.modes = &sharp_lq150x1lg11_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 304,
+		.height = 228,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,
+};
+
 static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = {
 	.clock = 33300,
 	.hdisplay = 800,
@@ -1641,6 +1665,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "sharp,lq123p1jx31",
 		.data = &sharp_lq123p1jx31,
 	}, {
+		.compatible = "sharp,lq150x1lg11",
+		.data = &sharp_lq150x1lg11,
+	}, {
 		.compatible = "shelly,sca07010-bfn-lnn",
 		.data = &shelly_sca07010_bfn_lnn,
 	}, {
-- 
2.1.4

Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote:
> From: Gustaf Lindström <gl@axentia.se>
> 
> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
> 
> The simple-panel driver is used to get support for essential
> functionality of the panel.
> 
> Signed-off-by: Gustaf Lindström <gl@axentia.se>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 85143d1b9b31..58cfe0a7a9d6 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = {
>  	},
>  };
>  
> +static const struct drm_display_mode sharp_lq150x1lg11_mode = {
> +	.clock = 71100,
> +	.hdisplay = 1024,
> +	.hsync_start = 1024 + 168,
> +	.hsync_end = 1024 + 168 + 64,
> +	.htotal = 1024 + 168 + 64 + 88,
> +	.vdisplay = 768,
> +	.vsync_start = 768 + 37,
> +	.vsync_end = 768 + 37 + 2,
> +	.vtotal = 768 + 37 + 2 + 8,
> +	.vrefresh = 60,
> +};
> +
> +static const struct panel_desc sharp_lq150x1lg11 = {
> +	.modes = &sharp_lq150x1lg11_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 304,
> +		.height = 228,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,

This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for
RGB565 panels.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 2024 bytes --]

On Wed, Oct 19, 2016 at 02:27:50PM +0200, Thierry Reding wrote:
> On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote:
> > From: Gustaf Lindström <gl@axentia.se>
> > 
> > The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
> > 
> > The simple-panel driver is used to get support for essential
> > functionality of the panel.
> > 
> > Signed-off-by: Gustaf Lindström <gl@axentia.se>
> > Signed-off-by: Peter Rosin <peda@axentia.se>
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 85143d1b9b31..58cfe0a7a9d6 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = {
> >  	},
> >  };
> >  
> > +static const struct drm_display_mode sharp_lq150x1lg11_mode = {
> > +	.clock = 71100,
> > +	.hdisplay = 1024,
> > +	.hsync_start = 1024 + 168,
> > +	.hsync_end = 1024 + 168 + 64,
> > +	.htotal = 1024 + 168 + 64 + 88,
> > +	.vdisplay = 768,
> > +	.vsync_start = 768 + 37,
> > +	.vsync_end = 768 + 37 + 2,
> > +	.vtotal = 768 + 37 + 2 + 8,
> > +	.vrefresh = 60,
> > +};
> > +
> > +static const struct panel_desc sharp_lq150x1lg11 = {
> > +	.modes = &sharp_lq150x1lg11_mode,
> > +	.num_modes = 1,
> > +	.bpc = 8,
> > +	.size = {
> > +		.width = 304,
> > +		.height = 228,
> > +	},
> > +	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,
> 
> This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for
> RGB565 panels.

Are you actually using the .bpc field in your driver? If yes, can you
please test if things work correctly if you set it to 6? If it's unused
I'm leaning towards just applying this with .bpc set to 6 and hope for
the best (and fix it if somebody finds that it's broken).

So no need to resend, just let me know what you think.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels

[Peter Rosin]

On 2016-10-19 14:31, Thierry Reding wrote:
> On Wed, Oct 19, 2016 at 02:27:50PM +0200, Thierry Reding wrote:
>> On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote:
>>> From: Gustaf Lindström <gl@axentia.se>
>>>
>>> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
>>>
>>> The simple-panel driver is used to get support for essential
>>> functionality of the panel.
>>>
>>> Signed-off-by: Gustaf Lindström <gl@axentia.se>
>>> Signed-off-by: Peter Rosin <peda@axentia.se>
>>> ---
>>>  drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
>>>  1 file changed, 27 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>>> index 85143d1b9b31..58cfe0a7a9d6 100644
>>> --- a/drivers/gpu/drm/panel/panel-simple.c
>>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>>> @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = {
>>>  	},
>>>  };
>>>  
>>> +static const struct drm_display_mode sharp_lq150x1lg11_mode = {
>>> +	.clock = 71100,
>>> +	.hdisplay = 1024,
>>> +	.hsync_start = 1024 + 168,
>>> +	.hsync_end = 1024 + 168 + 64,
>>> +	.htotal = 1024 + 168 + 64 + 88,
>>> +	.vdisplay = 768,
>>> +	.vsync_start = 768 + 37,
>>> +	.vsync_end = 768 + 37 + 2,
>>> +	.vtotal = 768 + 37 + 2 + 8,
>>> +	.vrefresh = 60,
>>> +};
>>> +
>>> +static const struct panel_desc sharp_lq150x1lg11 = {
>>> +	.modes = &sharp_lq150x1lg11_mode,
>>> +	.num_modes = 1,
>>> +	.bpc = 8,
>>> +	.size = {
>>> +		.width = 304,
>>> +		.height = 228,
>>> +	},
>>> +	.bus_format = MEDIA_BUS_FMT_RGB565_1X16,
>>
>> This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for
>> RGB565 panels.
> 
> Are you actually using the .bpc field in your driver? If yes, can you
> please test if things work correctly if you set it to 6? If it's unused
> I'm leaning towards just applying this with .bpc set to 6 and hope for
> the best (and fix it if somebody finds that it's broken).
> 
> So no need to resend, just let me know what you think.

Sorry for the delay, but I just tested .bpc = 6 and it was ok too. It
doesn't seem to matter for us, so do as you like.

Cheers,
Peter